Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract change to support KillBounty interface #926

Closed
stellarmagnet opened this issue May 27, 2019 · 0 comments
Closed

Contract change to support KillBounty interface #926

stellarmagnet opened this issue May 27, 2019 · 0 comments

Comments

@stellarmagnet
Copy link
Collaborator

stellarmagnet commented May 27, 2019

Currently, Projects.sol does not support the KillBounty function in StandardBounties.sol.

In order for us to kill bounties from the Projects app, we need to connect this function to our Projects.sol contract.
This requires adding KillBounty to the Projects Bounties interface.

In addition, we need an extremely simple function to clean up any local bounty state in Projects.sol and trigger the KillBounty function on the StandardBounties contract. This function should have a unique ROLE associated with it and should trigger an internal function. These functions should have the following signatures:

function removeBounties( bytes32[] _repoIds, uint256[] _issueNumbers) public auth(REMOVE_ISSUES_ROLE)
function _removeBounty( bytes32 _repoId, uint256 _issueNumber) internal

The kit will also need to be updated to set the REMOVE_ISSUES_ROLE, this role will need to be added to the arapp.json file, and the function will need to be tested in projects.test.js.

@stellarmagnet stellarmagnet added this to the Sprint 19.14 milestone May 29, 2019
@Quazia Quazia modified the milestones: Sprint 19.14, Sprint 19.15 Jun 10, 2019
e18r pushed a commit to e18r/open-enterprise that referenced this issue Jun 14, 2019
@Quazia Quazia added the bounty label Jun 18, 2019
e18r added a commit to e18r/open-enterprise that referenced this issue Jun 22, 2019
2019-06-21: initial submission
e18r added a commit to e18r/open-enterprise that referenced this issue Jun 22, 2019
2019-06-21: initial submission, corrected linter issues
e18r added a commit to e18r/open-enterprise that referenced this issue Jun 22, 2019
2019-06-21: initial submission, corrected linter issues, corrected
testing issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants