Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

582 - Increase projects contract coverage #860

Merged
merged 10 commits into from
May 9, 2019
Merged

582 - Increase projects contract coverage #860

merged 10 commits into from
May 9, 2019

Conversation

topocount
Copy link
Collaborator

@topocount topocount commented May 2, 2019 •
edited
Loading

  • Line 188: can't initialiaze with invalid vault address
  • Line 393: can't approve nonexistent assignment
  • Line 457: can't approve work for fulfilled bounty
  • Line 636 Test the token flow for this function fully; This may require multiple cases and covers the full function.

@topocount
Create tests to increase coverage
8292f66 
- Line 188: can't initialiaze with invalid vault address
- Line 393: can't approve nonexistent assignment
- Line 457: can't approve work for fulfilled bounty
@topocount
Merge branch 'dev' into 582-projects-test-coverage
0b9781c
@topocount
Increase Projects test coverage to 100%
3068e0c 
- cover requirement for xp array lengths: line 218
- cover token bounty activation handling: lines 657 - 661
@topocount
Merge branch 'dev' into 582-projects-test-coverage
c34b92a
@coveralls
Copy link

coveralls commented May 4, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 2301

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.3%) to 100.0%
Totals Coverage Status
Change from base Build 2299: 2.3%
Covered Lines: 308
Relevant Lines: 308
💛 - Coveralls

@topocount
Update Address Book tests
f0f8bed 
- add returns to assertRevert functions
- update getEntry test for nonexistent entries
@topocount
Update allocations tests
e5e7de3 
- cover getPayoutDescription getter
@topocount
Improve Rewards Contract Coverage
83bfe51 
- fix revert tests that weren't set up to run as async
- add initialization check for incorrect vault address
- add test cases for remaining uncovered requires
- remove trailing whitespace from contract
Quazia
Quazia requested changes May 7, 2019
View reviewed changes
Copy link
Collaborator

@Quazia Quazia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some of the tests are still set as pending, and there's some other minor cleanup needed but generally looks solid.

apps/projects/test/projects.test.js Show resolved Hide resolved
apps/rewards/test/Rewards.test.js Outdated Show resolved Hide resolved
apps/rewards/test/Rewards.test.js Outdated Show resolved Hide resolved
apps/projects/test/projects.test.js Outdated Show resolved Hide resolved
apps/projects/test/projects.test.js Outdated Show resolved Hide resolved
apps/projects/test/projects.test.js Outdated Show resolved Hide resolved
apps/projects/test/projects.test.js Outdated Show resolved Hide resolved
apps/projects/test/projects.test.js Outdated Show resolved Hide resolved
Quazia
Quazia approved these changes May 9, 2019
View reviewed changes
Copy link
Collaborator

@Quazia Quazia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tests

@topocount topocount merged commit 2a92ce6 into dev May 9, 2019
@chadoh chadoh deleted the 582-projects-test-coverage branch August 27, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quazia Quazia Quazia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@topocount @coveralls @Quazia