Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix/aut995] Fixed flooding of log when workflow fails to be loaded #399

Merged
merged 2 commits into from
Aug 2, 2021

Conversation

bertrandboudaud
Copy link
Collaborator

log flooding is fixed.
also, the panel shows that an error occurred.

included in this PR:

  • Workflow widget renamed WorkflowWodget for consistency
  • Added unit test. I don't like testing the protected methods and even more protected member variables, but we have no choice here (for UI objects). I think it makes sense if we select the ones that are very key to the internal logic (here: error flag is checked).

image

Copy link
Collaborator

@dmccloskey dmccloskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, the strategy of using protected methods instead of private methods to enable the use of unit testing is a suitable compromise. Looks good.

@bertrandboudaud bertrandboudaud merged commit 46f4a7c into develop Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants