Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive logging filled up the disk when an error occurred #257

Closed
Chillax-0v0 opened this issue Sep 26, 2023 · 1 comment
Closed

Excessive logging filled up the disk when an error occurred #257

Chillax-0v0 opened this issue Sep 26, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Chillax-0v0
Copy link
Contributor

For example, all object names will be logged here when the deletion of objects fails.

        return this.s3.deleteObjects(request).thenApply(resp -> {
            LOGGER.info("[ControllerS3Operator]: Delete objects: {}, cost: {}", Arrays.toString(resp.deleted().toArray()), System.currentTimeMillis() - start);
            return resp.deleted().stream().map(DeletedObject::key).collect(Collectors.toList());
        }).exceptionally(ex -> {
            LOGGER.error("[ControllerS3Operator]:Delete objects: {} failed", Arrays.toString(objectKeys.toArray()), ex);
            return Collections.emptyList();
        });
@Chillax-0v0
Copy link
Contributor Author

Migrate to AutoMQ/automq-for-rocketmq#176

daniel-y pushed a commit that referenced this issue Mar 14, 2024
Signed-off-by: Shichao Nie <niesc@automq.com>
ShadowySpirits pushed a commit that referenced this issue Mar 14, 2024
Signed-off-by: Shichao Nie <niesc@automq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant