Determine encoding only once in a few functions #5
Comments
|
Thanks for your small source code improvement. |
bgoldfai
added a commit
that referenced
this issue
Aug 1, 2016
* Moving deprecated Eigen to Eigen3 find package * Templatizes setupEnvVariables.sh * Adds support for launching cameras with only one camera connected. * Fixes config path typo in simulator launch files. * Removes unnecessary null checks in qnode. Fixes #4 * Refactors OCS image callbacks, pulling image formatting into a separate function. Fixes #5 * Adds error handling with console output to pthread mutex init and lock calls. Fixes #6 * added panos and evangelos websites * Added yaw rate to published state? * Fixes state estimator topic remapping. * Correct gyro with estimated bias * Removed compiler warnings * simplified wheel models so simulation is faster and updated all related files * Moved texinfo from recommended to installed by default. Closes #8 * Beginning to fix controller * updated waypoint/constant speed for simulator * Changes camera driver to the PointGrey ROS driver. * Fixes typo in camera calibration path. * Changes from recent test run * Disables built-in auto-balance on cameras. * Cleans up ImageRepublisher for consistency and performance. Fixes #1 * Switches to more efficient method of counting subscribers in ImageRepublisher. Switches to using cv_bridge's built-in pixel color / depth conversions in ImageRepublisher. Fixes #1 With this commit, ImageRepublisher CPU usage on Nuc platform is reduced to 0% and 10% with 0 subscribers and more than 0 subscribers respectively. * Enables triggering for pointgrey camera driver * Adds argument for controlling camera triggering to cameras.launch * Cleans up ChronyStatus folder and parameterizes server password. * Changes machine names to autorally-master and autorally-ocs. * Update PololuMaestro.cpp On line 118 array 'reply[2]' is accessed at index 19, which is out of bounds. * Updated readme * updated readme * updated readme * updated readme * updated readme * updated readme * Adds note to ArduinoOnBoard launch file about triggering limitations. * Updated chronyStatus to work with chrony 2.0+, new formate has a chronyStatus node runningon every maching * added chrony to automatically installed programs * Updated chrony files for new chrony interface, updated template files, removed files no longer needed * Added a couple comments to chronyClient * Fixed IMU time/integration bug. * moved waypoints file alongside the launch files that use it * moreupdates for new waypoints structure * integrating with camera auto balance * elevated message status from info to warn * Updated remappings and launch params for new naming scheme * initial commit for messages for new chassis controller * now generate headers for new messages successfully * inital commit for new chassis interface software including code shell and new messages * renamed folder to follow naming conventions * Stripping out and renaming chassis interface code * most features of new chassis interface implemented, but not yet tested with new chassis * Updated autobalance launch parameters * renamed .ino file to align with arduino IDE naming scheme * Change location of arduino code * fixed framing and actuator command message parsing in arduino code * cleaned up code and lowered serial timeout for the ESC * increased ESC state querying from 2 to 5 Hz * Added support for reading RC inputs * cleaned up and commented code * Added most of autorally_chassis stuff. Program is tested working within launch system on an autorally_chassis * added check to make sure ROS is still running before forcing a Diagnostics message to be published * Updated joystick control to use new autorally_chassis message interface * renabled compilation of nodes that were disabled for development * deprecated old chassis interface code * converted runstop to new chassis message interface (removed safeSpeed msg) * Updated xbee to use new autorally_msgs::runstop instead of deprecated autorally_msgs::safeSpeed * updating servoInterface to new messaging interface * Updated servoInterface with runstop and new chassis messages. Needs to be tested on hardware * Updated steer angle of simulator * Updated readme and moved Arduino Due UDEV rule in file * Updated udev rules ofr Arudino Due, improved readme, started covnersion of simulaiton to new messaging format * uncommented nodes that don't compile in kinetic yet since they shoudl not be commented out in this branch * converted simulation to new chassis interface messages * Integrated wheelspeeds into main autorally_controller for more accurate simulation * converted simulation and OCS to new chassis message interface * converted constant speed controller to new chassis interface * converted waypoint follower to new chassis interface * Added second instance of chrony status to run on OCS * included .msg and .srv files for doxygen file types * Removed all remaining references to old chassis messages and deleted the safeSpeed and servoMSG messages * Fixed errors from chassis message interface update, fixed node naming conflict for chronyStatus nodes on master and ocs * added servo commander informaion to servoInterface diagnostics * added placeholder text when frontBrakes aren't being controlled * Added check to AutoRallyChassis runstop in case all runstop messages are expired, cleaned up launch files * Removed some commented out code and cleaned up a little * fixed doxygen warnings * updated during pull request review #24 * re-added ROS deprecation to the old chassis interface code * Bug fixes to make code align with electronics diagrams * Tested updated chassis interface code with changes from pull request #24 * Fixing something weird that happened with the commits * Improved simulation testing step * Improved simulation testing step (#26) * Fixed broken OCS icon * removed unused icon image file and added more pthread error checking for issue #6 * More return value checking for Issue #6 * Update README.md * Update README.md * Update README.md * Update README.md
bgoldfai
added a commit
that referenced
this issue
Aug 4, 2016
* Moving deprecated Eigen to Eigen3 find package * Templatizes setupEnvVariables.sh * Adds support for launching cameras with only one camera connected. * Fixes config path typo in simulator launch files. * Removes unnecessary null checks in qnode. Fixes #4 * Refactors OCS image callbacks, pulling image formatting into a separate function. Fixes #5 * Adds error handling with console output to pthread mutex init and lock calls. Fixes #6 * added panos and evangelos websites * Added yaw rate to published state? * Fixes state estimator topic remapping. * Correct gyro with estimated bias * Removed compiler warnings * simplified wheel models so simulation is faster and updated all related files * Moved texinfo from recommended to installed by default. Closes #8 * Beginning to fix controller * updated waypoint/constant speed for simulator * Changes camera driver to the PointGrey ROS driver. * Fixes typo in camera calibration path. * Changes from recent test run * Disables built-in auto-balance on cameras. * Cleans up ImageRepublisher for consistency and performance. Fixes #1 * Switches to more efficient method of counting subscribers in ImageRepublisher. Switches to using cv_bridge's built-in pixel color / depth conversions in ImageRepublisher. Fixes #1 With this commit, ImageRepublisher CPU usage on Nuc platform is reduced to 0% and 10% with 0 subscribers and more than 0 subscribers respectively. * Enables triggering for pointgrey camera driver * Adds argument for controlling camera triggering to cameras.launch * Cleans up ChronyStatus folder and parameterizes server password. * Changes machine names to autorally-master and autorally-ocs. * Update PololuMaestro.cpp On line 118 array 'reply[2]' is accessed at index 19, which is out of bounds. * Updated readme * updated readme * updated readme * updated readme * updated readme * updated readme * Adds note to ArduinoOnBoard launch file about triggering limitations. * Updated chronyStatus to work with chrony 2.0+, new formate has a chronyStatus node runningon every maching * added chrony to automatically installed programs * Updated chrony files for new chrony interface, updated template files, removed files no longer needed * Added a couple comments to chronyClient * Fixed IMU time/integration bug. * moved waypoints file alongside the launch files that use it * moreupdates for new waypoints structure * integrating with camera auto balance * elevated message status from info to warn * Updated remappings and launch params for new naming scheme * initial commit for messages for new chassis controller * now generate headers for new messages successfully * inital commit for new chassis interface software including code shell and new messages * renamed folder to follow naming conventions * Stripping out and renaming chassis interface code * most features of new chassis interface implemented, but not yet tested with new chassis * Updated autobalance launch parameters * renamed .ino file to align with arduino IDE naming scheme * Change location of arduino code * fixed framing and actuator command message parsing in arduino code * cleaned up code and lowered serial timeout for the ESC * increased ESC state querying from 2 to 5 Hz * Added support for reading RC inputs * cleaned up and commented code * Added most of autorally_chassis stuff. Program is tested working within launch system on an autorally_chassis * added check to make sure ROS is still running before forcing a Diagnostics message to be published * Updated joystick control to use new autorally_chassis message interface * renabled compilation of nodes that were disabled for development * deprecated old chassis interface code * converted runstop to new chassis message interface (removed safeSpeed msg) * Updated xbee to use new autorally_msgs::runstop instead of deprecated autorally_msgs::safeSpeed * updating servoInterface to new messaging interface * Updated servoInterface with runstop and new chassis messages. Needs to be tested on hardware * Updated steer angle of simulator * Updated readme and moved Arduino Due UDEV rule in file * Updated udev rules ofr Arudino Due, improved readme, started covnersion of simulaiton to new messaging format * uncommented nodes that don't compile in kinetic yet since they shoudl not be commented out in this branch * converted simulation to new chassis interface messages * Integrated wheelspeeds into main autorally_controller for more accurate simulation * converted simulation and OCS to new chassis message interface * converted constant speed controller to new chassis interface * converted waypoint follower to new chassis interface * Added second instance of chrony status to run on OCS * included .msg and .srv files for doxygen file types * Removed all remaining references to old chassis messages and deleted the safeSpeed and servoMSG messages * Fixed errors from chassis message interface update, fixed node naming conflict for chronyStatus nodes on master and ocs * added servo commander informaion to servoInterface diagnostics * added placeholder text when frontBrakes aren't being controlled * Added check to AutoRallyChassis runstop in case all runstop messages are expired, cleaned up launch files * Removed some commented out code and cleaned up a little * fixed doxygen warnings * updated during pull request review #24 * re-added ROS deprecation to the old chassis interface code * Bug fixes to make code align with electronics diagrams * Tested updated chassis interface code with changes from pull request #24 * Fixing something weird that happened with the commits * Improved simulation testing step * Improved simulation testing step (#26) * Fixed broken OCS icon * removed unused icon image file and added more pthread error checking for issue #6 * More return value checking for Issue #6 * Update README.md * Update README.md * Update README.md * Update README.md * Added missing OCS icon image * Simplifies adding cameras to the platform agnostic launch system by making setupEnvVariables automatically query connected cameras without the need for udev rules. * Imports CameraAutoBalance. * Fixes #31, which was a reintroduction of issue #2 by changing the command priorities file from servoCommandPriorities.yaml to chassisCommandPriorities.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Should it be avoided to check the data structure member "encoding" more than it is required in the functions "QNode::imageCallback1" and "QNode::imageCallback2"?
The text was updated successfully, but these errors were encountered: