Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update license to MIT #537

Merged
merged 3 commits into from
Aug 5, 2023
Merged

docs: update license to MIT #537

merged 3 commits into from
Aug 5, 2023

Conversation

benwandrew
Copy link
Collaborator

@benwandrew benwandrew commented Aug 1, 2023 •
edited
Loading

Description

resolves #533

Type of change

  • docs: Documentation only changes

Questions (Optional)

  • would this actually be categorized as a docs change (in which case, title of PR and the branch should be different)? wasn't sure which type was best...
  • when I selected MIT within "Choose a license template", it defaulted to a file name without the .md suffix; does this matter? seems like either is permissible?

Remarks (Optional)

  • I will create a new release once this is approved and merged.

@benwandrew benwandrew mentioned this pull request Aug 1, 2023
Closed
hollandjg
hollandjg requested changes Aug 1, 2023
View reviewed changes
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ben, thanks for this! I think the license file name needs updating in the pyproject.toml file too.

@benwandrew benwandrew changed the title chore: update license to MIT docs: update license to MIT Aug 4, 2023
@benwandrew
Copy link
Collaborator Author

Hi Ben, thanks for this! I think the license file name needs updating in the pyproject.toml file too.

@hollandjg guess this needs your approval to merge?

@benwandrew benwandrew added this pull request to the merge queue Aug 5, 2023
Merged via the queue into main with commit 5a6d6d5 Aug 5, 2023
15 checks passed
@benwandrew benwandrew deleted the chore/update-license branch August 5, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesStrittmatter younesStrittmatter younesStrittmatter approved these changes

@hollandjg hollandjg hollandjg approved these changes

@musslick musslick Awaiting requested review from musslick

@chadcwilliams chadcwilliams Awaiting requested review from chadcwilliams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update license to MIT
3 participants
@benwandrew @hollandjg @younesStrittmatter