Fix dropping columns with zero var in transform #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added one line in transform()
In the subsequent steps, feature selection using Sulov and XGBoost is performed on the df.
If
df.drop(self.cols_zero_variance, axis=1)
is not executed, there is a possibility that features not present in X_sel will be selected, which could lead to a KeyError whenreturn X_sel[self.features], y_sel
is executed.