Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added external force and fixed dtype issues #63

Merged
merged 11 commits into from
Sep 18, 2024

Conversation

hsalehipour
Copy link
Collaborator

This PR:

  1. adds external force due to exact difference method as new operator
  2. adds ForcedCollision as a new way of defining the collision operator (either BGK or KBC)
  3. adds a turbulent 3d benchmakr example with reference DNS and theory data for testing 1 and 2 above.
  4. fixes a bug in my PR Added boundary force computation and more #61 where interior boundaries that touched the domain bounds would not be properly handled.
  5. added a flag to boundary condition to indicate where "index padding" is needed for BCs that required missing directions.
  6. fixes all previous pytest issues
  7. fixes all issues (caught so far) related to dtype other than fp32 in Warp kernels

@hsalehipour
Copy link
Collaborator Author

hsalehipour commented Sep 17, 2024

Results obtained by running the recently added benchmark example on turbulent channel flow with fp32/fp32. Comparisons are made with DNS data of Moser and Kim (1999) (solid line), as well as the log-law of wall (dashed line)

turbulent_channel_3d_3300000
uplus_00330

@mehdiataei mehdiataei merged commit 3ff0814 into Autodesk:major-refactoring Sep 18, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants