Fix incorrect dates shown at ends of time ranges #149
Conversation
|
@toddocon: I discovered this issue while debugging your bug report in #147. I think this one could be related or even the explanation for #147, but I’m not entirely sure. I manually set my time zone to PST, and all dates look fine to me now. So if you could try out this patch, this would be much appreciated 😄. Also, when testing this, could you check whether the bug in #118 still persists on your side? |
pluehne
changed the title
docs/assets/js/charts.js
Outdated
| @@ -429,7 +429,7 @@ function createHistoryChart(canvas, actionBar) | |||
|
|
|||
| // The date range is of the form [t0, t1), inclusive of t0 but exclusive of t1. | |||
| // Hence, subtract one second from t1 to obtain the previous date in UTC | |||
| let t1 = dateRange[1]; | |||
There was a problem hiding this comment.
Do you see an easy way to cover that with a test case? E.g. move tooltipTitleCallback to a "real" function and then test this function with some demo data?
There was a problem hiding this comment.
I thought about this as well, but now that you think of unit-testing this as well, I probably should do this tomorrow 🙂.
This adds Moment time zone support. While this isn’t needed from the dashboard, we’ll need the library for mocking up custom time zones, which is useful when unit-testing functions related to date and time.
Because of a mistake, the end date of time ranges as shown in the dashboard was not copied by value but by reference. As an effect, displayed dates would be repeatedly decremented by one second every time users hovered data points. For this reason, displayed dates could vary when hovering them multiple times. This is easily fixed by copying the affected variable by value. Multiple test cases ensure that no off-by-one errors or local time zone issues occur.
pluehne
force-pushed
the
patrick/fix-incorrect-dates-at-range-end
branch
from
f8e1e83
to
03e647d
Compare
|
@larsxschneider: I added some unit tests, so please review this again 🙂. |
Because of a mistake, the end date of time ranges as shown in the dashboard was not copied by value but by reference. As an effect, displayed dates would be repeatedly decremented by one second every time users hovered data points. For this reason, displayed dates could vary when hovering them multiple times.
This is easily fixed by copying the affected variable by value.