Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API Requests By User #156

Merged
merged 2 commits into from
Apr 24, 2018
Merged

Add API Requests By User #156

merged 2 commits into from
Apr 24, 2018

Conversation

larsxschneider
Copy link
Collaborator

PR with a few minor improvements for #148

This adds a report to collect the top 20 API users each day.
Reports this info in a simple table, this is handy for identifying
users who are approaching, or over the API rate limit.

zcat -f /var/log/github/unicorn.log.1* |
grep -F 'request_category=api' |
grep -Fv 'remote_address=127.0.0.1' |
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfarr I excluded internal API calls here as they are not directly issued by a user (e.g. Git LFS requests)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍

></canvas>
<div class="info-box">
<p>
The top 20 users that made the highest number of API requests yesterday.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“who” instead of ”that” might sound nicer.

Copy link
Contributor

@pluehne pluehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larsxschneider: Thanks for removing internal API calls, hadn’t thought of that. I just have one minor remark (see below).

Copy link
Contributor

@pluehne pluehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I’ll merge this in a second!

@pluehne pluehne merged commit 9abba5b into master Apr 24, 2018
@pluehne pluehne deleted the dfarr-feature/api-rate-limit branch April 24, 2018 16:42
@pluehne
Copy link
Contributor

pluehne commented Apr 24, 2018

Thanks again, @dfarr!

larsxschneider pushed a commit that referenced this pull request Apr 24, 2018
This adds a report to collect the top 20 API users each day.
Reports this info in a simple table, this is handy for identifying
users who are approaching or over the API rate limit.
@larsxschneider
Copy link
Collaborator Author

Thanks @dfarr from me too 👍 ! Please note, we just rebased the master branch. Somehow your authorship disappeared with the squash merge but I repaired: b734a91

@larsxschneider
Copy link
Collaborator Author

9 contributors, yay! https://github.com/Autodesk/hubble/graphs/contributors

@pluehne
Copy link
Contributor

pluehne commented Apr 24, 2018

That graph even shows 10 contributors now 😉.

@dfarr
Copy link
Contributor

dfarr commented Apr 24, 2018

Thanks guys! Always great to see your contributions in the graph :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants