Make data labels consistent #5
Conversation
|
I forgot to update the HTML part accordingly. I will fix this! |
| @@ -1,4 +1,4 @@ | |||
| date Pull request usage in % Status usage in % | |||
| date pull request usage [%] status usage [%] | |||
There was a problem hiding this comment.
Is this some kind of standard? I think in % reads easier, no?
There was a problem hiding this comment.
Yep, that’s how you usually denote the unit of an axis. I think it looks more professional like this.
There was a problem hiding this comment.
Also keep in mind that I want to show the unit on the axes directly at some point. Parsing might be easier with this bracket notation.
There was a problem hiding this comment.
parsing is a convincing argument! 👍
| ROUND(100*COUNT(pr.repository_id)/COUNT(active.repository_id)) AS "Pull request usage in %", | ||
| ROUND(100*COUNT(status.repository_id)/COUNT(active.repository_id)) AS "Status usage in %" | ||
| ROUND(100*COUNT(pr.repository_id)/COUNT(active.repository_id)) AS "pull request usage [%]", | ||
| ROUND(100*COUNT(status.repository_id)/COUNT(active.repository_id)) AS "status usage [%]" |
There was a problem hiding this comment.
are these names used anywhere? just to make sure we don't break anything here ;-)
There was a problem hiding this comment.
Yes, these are the labels shown in this chart:
There was a problem hiding this comment.
It’s the actual results if I see that correctly, and not just intermediate subquery results.
The data labels are currently formatted inconsistently. This pull request turns all labels into lowercase (except acronyms etc.) and updates the demo data accordingly.