fix: pre-commit fixes and flake8 config #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some new entries to pre-commit to help on this project. It also adds a few supporting files: * .prettierignore - like gitignore/dockerignore, but for prettier which formats files. This ignores all files in the .github folder * .github/workflows/constraints.txt - This is a requirements.txt file for the base tools used in the repo. It defines pip, poetry, and virtualenv versions The pre-commit runs the following checks: * black - automatic code formatting * check-added-large-files - Tries to prevent checking large files/binaries into git * check-toml - Lints toml files (pyproject.toml) * check-yaml - Lints yaml files * end-of-file-fixer - Makes sure all files end in a new line * flake8 - python style linting * pyupgrade - automatically upgrades python syntax for newer versions of python. Currently set for python 3.7 and greater * reoder-python-imports - sorts python imports in python files into groups * trailing-whitespace - trims trailing whitespaces from lines * prettier - generic file formatter I added dev requirements to pyproject.toml for all of these pre-commits
vjeeva
force-pushed
the
vjeeva/pre-commit-fixes
branch
from
b6e3537
to
a004b67
Compare
This was referenced Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.