Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arnold 5.4.0 to master #80

Merged
merged 110 commits into from
Sep 25, 2019
Merged

Arnold 5.4.0 to master #80

merged 110 commits into from
Sep 25, 2019

Conversation

JenusL
Copy link
Contributor

@JenusL JenusL commented Sep 17, 2019

When 5.4.0 #76 and AdLM patch #79 is merged in to develop I think it's time to get this in to master and make a real release. We should test Linux first though.

sjannuz and others added 30 commits February 1, 2019 18:09
trying to reuse existing shader parsing code which would skip params which are not inspectable
for siShaderArrayParameterID param type added support for arnold arrays of node type
Set normal to non inspectable on bump and lambert
added as Instantaneous Shutter
and changed the category from Texture to Utility
and added desc to the existing matrix shaders
@sjannuz
Copy link
Contributor

sjannuz commented Sep 19, 2019

@JenusL , I have a couple of build errors in linux, in particular this one:

plugins/sitoa/renderer/RenderInstance.cpp:234: error: 'std::thread' has not neen declared

@JenusL
Copy link
Contributor Author

JenusL commented Sep 19, 2019

Ok so it seems the old GCC doesn't support that.
I only use it to get number of threads. Is there any way in the Arnold API I can get the number of cores / threads? I have searched for it but didn't find any but maybe there's something undocumented?

@sjannuz
Copy link
Contributor

sjannuz commented Sep 19, 2019

What suggested here https://stackoverflow.com/questions/150355/programmatically-find-the-number-of-cores-on-a-machine seems to build fine.
Unfortunately I can build but not test it. I'll upload the addon soon.

@sjannuz sjannuz marked this pull request as ready for review September 19, 2019 15:30
@sjannuz
Copy link
Contributor

sjannuz commented Sep 19, 2019

Are you ok with my changes @JenusL ?

@JenusL
Copy link
Contributor Author

JenusL commented Sep 19, 2019

Yeah I'm fine with your changes :)

@JenusL
Copy link
Contributor Author

JenusL commented Sep 19, 2019

@sjannuz If you can provide a build then maybe @knekke can test it a little bit? :)

@sjannuz
Copy link
Contributor

sjannuz commented Sep 20, 2019

For now I've uploaded the addons here:
https://drive.google.com/drive/folders/1ZdXjsmJQKXl-VRSy_edSa17V1Kyry5Hm?usp=sharing

@JenusL
Copy link
Contributor Author

JenusL commented Sep 20, 2019

@sjannuz Windows package seems to work fine but it doesn't have the AdLM patch applied. Any reason for that?
@knekke Do you think you have time to test the Linux addon some time?

@sjannuz
Copy link
Contributor

sjannuz commented Sep 23, 2019

@sjannuz Windows package seems to work fine but it doesn't have the AdLM patch applied. Any reason for that?

My bad, I hadn't updated the build machine. I have now replaced the addon in the above location.

@knekke
Copy link

knekke commented Sep 24, 2019

@JenusL It's running on Fedora. Just a very quick test though...

@JenusL
Copy link
Contributor Author

JenusL commented Sep 24, 2019

Tried the new addon and patch is ok now.
@knekke Thanks Thomas!
So release?

@sjannuz sjannuz merged commit 46b7de8 into master Sep 25, 2019
@sjannuz
Copy link
Contributor

sjannuz commented Sep 25, 2019

@JenusL draft release ready, see https://github.com/Autodesk/sitoa/releases.
Do you have some release notes ready to add ?

@JenusL
Copy link
Contributor Author

JenusL commented Sep 25, 2019

@sjannuz Great! I can write some release notes now. Will post them soon.

@JenusL
Copy link
Contributor Author

JenusL commented Sep 25, 2019

@sjannuz I don't think I have permission to see the draft release but here's a quick changelog i put together: https://gist.github.com/JenusL/f473d32fab463767e6b4a79b6dae1e7e

@sjannuz
Copy link
Contributor

sjannuz commented Sep 25, 2019

Released.
Thankyou @JenusL for your passionate work.

@JenusL
Copy link
Contributor Author

JenusL commented Sep 25, 2019

Add thank you @sjannuz for still supporting me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants