-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CrashLogging: New Error Logging API #274
Conversation
|
||
dataProvider.didLogErrorCallback?(event) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No easy way to unit test this. I've tinkered with the idea of adding didLogTaggedErrorCallback
, but TBH the entire test felt pointless, since it would only be able to evaluate that the callback gets invoked 😆
/// - Parameters: | ||
/// - error: The error object | ||
/// - tagName: Tag name to be associated with the error | ||
/// - tagValue: Tag's value to be associated with the error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variables here (tagName
& tagValue
) don't match the function.
CI seems to be failing because of a couple new warnings, unrelated to this PR. Merging this one back into Trunk. Thanks a lot Tony!! |
Details:
We'll be using Sentry to track down Sync-Errors in DayOne. While testing the main integration PR, I've noticed it was next to impossible to filter by a given event's Additional Data fields.
You can find a Sample Event Here, with the
Additional Data
set (but no Tags)Since Sentry recommends using Enriched Events, which can then be filtered with the keyword
has:
., in this PR we're adding an extra API that allows us to set aTag/Value
pair in the event's context.cc @jkmassel (Thanks a lot in advance!!
CHANGELOG.md
if necessary.