Enhancement / Date format setting #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blished date using the date format defined in the plugin settings.
… job using the display format selected in the plugin settings.
…b_publish_date" function.
…etime attribute defined. This closes Automattic#739
…date format is used.
|
Sorry this took a while to properly review. This looks good to me. @cwpnolen: can you please fix the conflicts with master? I'll get this merged soon after. Thanks! |
|
No worries @dbtlr I have fixed the conflicts with master. Please take a look. |
|
Perfect, thanks @cwpnolen. I'll be merging this soon. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow the user to define how they would like their job listing dates to be formatted. This works as follows:
This required creating a new function "the_job_publish_date" and has the added benefit to make the rendered date more DRY. Also added an additional function "get_the_job_publish_date" that returns only the formatted date. This function is not being used currently and was only put in as a future consideration.
Also updated the element to use the element with the datetime attribute.