Use Google Maps Geocode API's new endpoint and add API key #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jom
added
[Status] In Progress
[Pri] High
pgk
approved these changes
Mar 28, 2017
dbtlr
added
[Type] Enhancement
[Status] Ready To Merge
and removed
[Type] Enhancement
labels
jom
force-pushed
the
fix/712-google-maps-api
branch
from
d9d2187
to
dd00be5
Compare
|
Makes sense to put the language file update in a different commit. I've updated the PR and pulled out that file into a separate commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #712
This adds a setting for a Google Maps API Key and uses it when forming the URL for retrieving the geocode API result and uses the new endpoint for the geocode API service.