Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and extend IE comments #611

Closed
wants to merge 1 commit into from
Closed

Remove and extend IE comments #611

wants to merge 1 commit into from

Conversation

emiluzelac
Copy link
Contributor

_s does not support IE8, therefore no need to keep the references. Also extending couple of items to IE10/11

https://github.com/necolas/normalize.css/blob/master/normalize.css#L394
https://github.com/necolas/normalize.css/blob/master/normalize.css#L332

```_s``` does not support IE8, therefore no need to keep the references. Also extending couple of items to IE10/11

https://github.com/necolas/normalize.css/blob/master/normalize.css#L394
https://github.com/necolas/normalize.css/blob/master/normalize.css#L332
@obenland
Copy link
Member

We should just make the move to normalize all together already.

@emiluzelac
Copy link
Contributor Author

I am in 👍

On Tuesday, September 9, 2014, Konstantin Obenland notifications@github.com
wrote:

We should just make the move to normalize all together already.


Reply to this email directly or view it on GitHub
#611 (comment).

@philiparthurmoore
Copy link
Collaborator

@obenland As in drop the hard reset?

html, body, div, span, applet, object, iframe,
h1, h2, h3, h4, h5, h6, p, blockquote, pre,
a, abbr, acronym, address, big, cite, code,
del, dfn, em, font, ins, kbd, q, s, samp,
small, strike, strong, sub, sup, tt, var,
dl, dt, dd, ol, ul, li,
fieldset, form, label, legend,
table, caption, tbody, tfoot, thead, tr, th, td {
    border: 0;
    font-family: inherit;
    font-size: 100%;
    font-style: inherit;
    font-weight: inherit;
    margin: 0;
    outline: 0;
    padding: 0;
    vertical-align: baseline;
}

If so, I am 1000000% behind this. But maybe I'm jumping the gun here. 😄

@emiluzelac
Copy link
Contributor Author

Do I have your blessing to proceed with http://necolas.github.io/normalize.css/3.0.1/normalize.css or we have other plans?

@philiparthurmoore
Copy link
Collaborator

I think that should be a separate Issue for discussion. Seems like something that's pretty important, no?

@philiparthurmoore
Copy link
Collaborator

What I mean is that this pull request is super-minor, whereas moving _s to Normalize is something else entirely and worthy of its own Issue thread.

@obenland
Copy link
Member

As in drop the hard reset?

Exactly.

This has been brought up before of course, as early as the third ticket on this project. (#3, #44, #174, and #267)
Making the change is unfortunately not as easy as it sounds, since Eric Meyer's reset, normalize, and some basic styles are baked together. I tried to take a stab at it a while back, but couldn't decide what the best way forward would be in terms of separating normalize and basic styles.

I agree though, it should be its own issue, and I think it would be great to have @ianstewart's opinion on it as well.

@emiluzelac
Copy link
Contributor Author

Close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants