For rem value of font-size mixin, first divide $sizeValue by 1.6 ... #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce in browsers, 1rem is equal to 16px if 1.6 is passed, we'd expect 1rem (1.6/1.6) = 1rem if we passed 2.4 expecting 24px, we end up with 1.5 rem. 16 * 1.5 = 24px.
Not necessarily, and unfortunately not in our case. The rem unit is relative to the root—or the html—element. Since we set the font-size there to 10px, it's relative to that. One more reason to make #617 happen asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...since in browsers, 1rem is equal to 16px
if 1.6 is passed, we'd expect 1rem (1.6/1.6) = 1rem
if we passed 2.4 expecting 24px, we end up with 1.5 rem. 16 * 1.5 = 24px.
Old method would essentially add:
font-size: 16px;
font-size: 25.6px (because 1.6 rem = 16px * 1.6)