Apply Hfeed to Singular Posts Only

[dshanske]

Addresses #740 by applying hfeed to the body only on archive and index pages.

[grappler]

@dshanske You should use the WordPress coding standards. https://make.wordpress.org/core/handbook/coding-standards/php/

[dshanske]

Assuming it was the tabbing. It has been said I am tab challenged. Expandtabs was set on vi. It looked the same from my end till I saw it on github.

[grappler]

The tabs and also the spacing in if (!is_singular() ) {. I think you also missed a tab before the comment. Once you are able to make the changes you should squash the commits together. https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit

[dshanske]

Think I fixed everything.

[obenland]

We probably need to be more restrictive. hfeed should only be added if it's a list of posts.

[dshanske]

hfeed is supposed to be a list of hentrys, hentrys being datestamped content. WordPress unfortunately, puts hentry on everything...which is another pet-peeve of mine.

But are you suggesting is_single, or something broader?

[obenland]

But are you suggesting is_single, or something broader?

I'm suggesting something more limited actually, that would only apply to screens with lists of date-stamped posts.

[dshanske]

What's the rationale for that? A use case for hfeed is that a page of hentrys identified with an hfeed is a substitute for atom or rss that uses the existing html page. What you describe is the equivalent of an excerpt feed.

[dshanske]

The official definition of hfeed is a collection of hentrys. Therefore, it would apply on any page that had multiple hentrys.

[obenland]

Therefore, it would apply on any page that had multiple hentrys.

Agreed.

[dshanske]

Any movement on this?

[davidakennedy]

We addressed here: #820 Looks like we didn't realize we already an earlier PR. Closing this out.