-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Codesniffer errors. #762
Merged
philiparthurmoore
merged 1 commit into
Automattic:master
from
fklein-lu:fix/coding-standards-issues
May 28, 2015
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ | |
* | ||
* @package _s | ||
*/ | ||
|
||
?> | ||
|
||
</div><!-- #content --> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,6 @@ | |
* as indicating support for post thumbnails. | ||
*/ | ||
function _s_setup() { | ||
|
||
/* | ||
* Make theme available for translation. | ||
* Translations can be filed in the /languages/ directory. | ||
|
@@ -39,7 +38,7 @@ function _s_setup() { | |
* | ||
* @link http://codex.wordpress.org/Function_Reference/add_theme_support#Post_Thumbnails | ||
*/ | ||
//add_theme_support( 'post-thumbnails' ); | ||
add_theme_support( 'post-thumbnails' ); | ||
|
||
// This theme uses wp_nav_menu() in one location. | ||
register_nav_menus( array( | ||
|
@@ -51,15 +50,23 @@ function _s_setup() { | |
* to output valid HTML5. | ||
*/ | ||
add_theme_support( 'html5', array( | ||
'search-form', 'comment-form', 'comment-list', 'gallery', 'caption', | ||
'search-form', | ||
'comment-form', | ||
'comment-list', | ||
'gallery', | ||
'caption', | ||
) ); | ||
|
||
/* | ||
* Enable support for Post Formats. | ||
* See http://codex.wordpress.org/Post_Formats | ||
*/ | ||
add_theme_support( 'post-formats', array( | ||
'aside', 'image', 'video', 'quote', 'link', | ||
'aside', | ||
'image', | ||
'video', | ||
'quote', | ||
'link', | ||
) ); | ||
|
||
// Set up the WordPress core custom background feature. | ||
|
@@ -120,7 +127,7 @@ function _s_scripts() { | |
/** | ||
* Implement the Custom Header feature. | ||
*/ | ||
//require get_template_directory() . '/inc/custom-header.php'; | ||
require get_template_directory() . '/inc/custom-header.php'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I also think that uncommenting this is totally fine as well. It always struck me as weird that _s had commented code for functionality like featured post thumbnails and the custom header. Thanks for handling this. |
||
|
||
/** | ||
* Custom template tags for this theme. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ | |
* | ||
* @package _s | ||
*/ | ||
|
||
?><!DOCTYPE html> | ||
<html <?php language_attributes(); ?>> | ||
<head> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is totally fine. I'm okay with uncommenting this.