Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown: Enabling does nothing on latest master #6442

Closed
aheckler opened this issue Feb 18, 2017 · 3 comments
Closed

Markdown: Enabling does nothing on latest master #6442

aheckler opened this issue Feb 18, 2017 · 3 comments
Assignees
Labels
[Feature] Markdown [Pri] BLOCKER [Type] Bug When a feature is broken and / or not performing as intended
Milestone

Comments

@aheckler
Copy link
Member

To repro:

  1. Run latest master of Jetpack.
  2. With Markdown module off, enable it.
  3. Add a new post/page, enter some markdown.
  4. Publish it.

What I expected: markdown to be changed to HTML.

What happened: markdown comes out raw. Screenshot:

screen shot 2017-02-18 at 10 05 00 am

I think this is because the new setting under Settings > Writing does not automatically get turned on:

screen shot 2017-02-18 at 10 05 46 am

Probably related to #6406 cc @eliorivero

@aheckler aheckler added [Feature] Markdown [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended labels Feb 18, 2017
@stoyan0v
Copy link
Contributor

stoyan0v commented Mar 2, 2017

It seems that there are two PRs for Markdown module.
The first one is #6406 and it adds new endpoint and removes the code that enables the module.

The second one #6396 is similar to the first one, but it has additional commit (8c1ba3d) which contains the code for enabling the module ( this code is missing in master branch right now ).

The issue is that the second PR is merged in feature/settings-overhaul branch not in master, while the first one is merged in master. So I think that if the feature/settings-overhaul branch will be merged in master before 4.7 release, the module will work as expected.

cc @jeherve @eliorivero

@jeherve
Copy link
Member

jeherve commented Mar 2, 2017

@eliorivero Do you think we should bring that commit over to master?

@eliorivero
Copy link
Contributor

@jeherve that commit referenced by @stoyan0v is only for the new settings UI.

I'll try to devise something for the current UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Markdown [Pri] BLOCKER [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

4 participants