Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings UI: allow to independently toggle Markdown for posts and for comments #6396

Conversation

eliorivero
Copy link
Contributor

@eliorivero eliorivero commented Feb 14, 2017

Fixes #6311

See p6TEKc-HQ-jpopdesignp2, comment-2128 by @tyxla

Changes proposed in this Pull Request:

  • allow to toggle Markdown for posts and for comments independent of each other
  • whitelist option for Markdown for posts.
  • remove code in markdown.php that forcefully enables Markdown for posts every time the option is attempted to be written.
  • when both are toggled off, the Markdown module is disabled

🗒 the first commit won't be needed if it's merged in #6406

Testing instructions:

  • test the markdown options for posts and comments in Writing and Discussion respectively. Each one should work correctly and independently.

@eliorivero eliorivero added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Feb 14, 2017
@eliorivero eliorivero added this to the Settings UI milestone Feb 14, 2017
@eliorivero eliorivero self-assigned this Feb 14, 2017
@eliorivero eliorivero added this to Review needed in Settings UI Feb 14, 2017
@eliorivero eliorivero force-pushed the update/deactivate-markdown-posts-separately branch from 8e1ea71 to 3cda3ce Compare February 14, 2017 01:56
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm 👍 Thanks for that!

Just a side note: I think we don't really need to disable the module at all - after all, it doesn't do any damage if all post types are disabled, but the module is enabled, right? But that's your call really.

@eliorivero
Copy link
Contributor Author

It's better to disable it so Jetpack doesn't attempt to load the file.

@tyxla tyxla added [Status] Invalid [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Status] Invalid labels Feb 14, 2017
@zinigor zinigor moved this from Review needed to Review complete in Settings UI Feb 14, 2017
…forcefully enables Markdown for posts every time the option is about to be written.
@eliorivero eliorivero force-pushed the update/deactivate-markdown-posts-separately branch from 8506a3a to 8c1ba3d Compare February 14, 2017 22:37
@eliorivero eliorivero merged commit 03d0068 into feature/settings-overhaul Feb 15, 2017
@eliorivero eliorivero deleted the update/deactivate-markdown-posts-separately branch February 15, 2017 17:04
@eliorivero eliorivero removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 15, 2017
@eliorivero eliorivero moved this from Review complete to Done in Settings UI Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants