Plans: Make sure the option we store plan info in is autoloaded in the single autoload options query when not in the cache. #11133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e single autoload options query when not in the cache. This ensures that we can't end up with a cached notoption if we try and query the option before it is set.
westi
added
[Status] Needs Review
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: February 5, 2019. |
jeherve
added
[Status] Ready to Merge
jeherve
approved these changes
Jan 18, 2019
ghost
removed
the
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that we can't end up with a cached notoption if we try and query the option before it is set.
Changes proposed in this Pull Request:
Testing instructions:
Proposed changelog entry for your changes:
Not needed