Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Package: Moves the Protect sync module #12718

Closed
wants to merge 2 commits into from

Conversation

roccotripaldi
Copy link
Member

We are trying to move away from class mapped packages, and unspool all of the dependencies within a package.

So let's do this!

Part of #12712

Changes proposed in this Pull Request:

This PR should have no functional changes. The Protect sync module should function exactly the same as before.

Note, the Protect module will need its own package, but we'll handle that in an other PR.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

This modifies an existing part of Jetpack.

Testing instructions:

  • Try this branch out on a Jurassic.ninja site or on your docker testing site.
  • Connect the site and activate the recommended features.
  • Point your testing site to your .com sandbox to observe sync actions in real time.
  • Log out of your testing site, and login with a incorrect username / password
  • Do you see the sync action for jetpack_valid_failed_login_attempt

Proposed changelog entry for your changes:

@roccotripaldi roccotripaldi added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Package] Sync [Focus] Jetpack DNA labels Jun 17, 2019
@roccotripaldi roccotripaldi requested a review from a team as a code owner June 17, 2019 23:50
@roccotripaldi roccotripaldi self-assigned this Jun 17, 2019
@jetpackbot
Copy link

jetpackbot commented Jun 17, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: July 2, 2019.
Scheduled code freeze: June 25, 2019

Generated by 🚫 dangerJS against 19deca2

composer.lock Outdated Show resolved Hide resolved
@roccotripaldi roccotripaldi force-pushed the add/protect-module-sync-package branch 3 times, most recently from f51a5e2 to adec596 Compare June 19, 2019 15:07
composer.lock Outdated Show resolved Hide resolved
@roccotripaldi roccotripaldi force-pushed the add/protect-module-sync-package branch 2 times, most recently from 7303bb8 to 72f5220 Compare June 20, 2019 17:07
gititon
gititon previously approved these changes Jun 20, 2019
@@ -1,25 +0,0 @@
<?php

use Automattic\Jetpack\Constants;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make sure we git mv instead!

@jeherve jeherve added this to the 7.5 milestone Jun 21, 2019
@roccotripaldi roccotripaldi force-pushed the add/protect-module-sync-package branch from ad899af to 19deca2 Compare June 21, 2019 19:13
@roccotripaldi roccotripaldi deleted the add/protect-module-sync-package branch June 21, 2019 19:17
@kraftbj kraftbj removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants