-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync Package: Moves the Protect sync module #12718
Conversation
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: July 2, 2019. |
f26c4f3
to
9d3c92b
Compare
f51a5e2
to
adec596
Compare
7303bb8
to
72f5220
Compare
@@ -1,25 +0,0 @@ | |||
<?php | |||
|
|||
use Automattic\Jetpack\Constants; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's make sure we git mv
instead!
…kage to psr-4 class within the package.
…nc\Modules\Constants
ad899af
to
19deca2
Compare
We are trying to move away from class mapped packages, and unspool all of the dependencies within a package.
So let's do this!
Part of #12712
Changes proposed in this Pull Request:
This PR should have no functional changes. The Protect sync module should function exactly the same as before.
Note, the Protect module will need its own package, but we'll handle that in an other PR.
Is this a new feature or does it add/remove features to an existing part of Jetpack?
This modifies an existing part of Jetpack.
Testing instructions:
jetpack_valid_failed_login_attempt
Proposed changelog entry for your changes: