Sync: Ensure a post object is returned

[kraftbj]

Fixes #13657

Changes proposed in this Pull Request:

• Defensive coding for when a post is not returned from get_post.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

• n/a

Testing instructions:

• Don't have a specific testing steps. I presume something like publish a post, but before it syncs, delete it totally.

Proposed changelog entry for your changes:

• Sync: Prevent a PHP Notice in some cases where a post isn't actually a post.

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against a61e2a5

[mdawaffe]

Makes sense to me. I don't know how to reproduce, though. Do you think the notice from #13657 means that sync is broken for that site?

[kraftbj]

Do you think the notice from #13657 means that sync is broken for that site?

In and of itself, I don't know. My best guess, since it is firing off of a post_id int value, the value being passed to it isn't a read post anymore. I could see something like a post that was created, sync was about to start, the post was fully deleted (so nothing in the db), sync still has the post in the queue, and the issue occurs. Maybe the post was deleted at exactly the right time or maybe deleted outside of the typical WP functions.

That's just a total guess though.