Actions: Auto-labeling, testing changes to a package #18722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![test-case-reminder[bot]](https://avatars.githubusercontent.com/u/1306301?s=60&v=4){kind=small}
There was a problem hiding this comment.
Here are some suggested test cases for this PR.
Connection
- In-place connection with free plan
- In-place connection with paid plan
- In-place connection with product purchase
- Classic connection. Use Safari, or set a constant
JETPACK_SHOULD_NOT_USE_CONNECTION_IFRAMEto true - Disconnect/reconnect connection
- Secondary user connection
- Connection on multisite
Verify that the changes are compatible with the plugins that use the connection package.
- WooCommerce Payments
- Jetpack Boost
- Previous versions of Jetpack
If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.
github-actions
bot
added
[Package] Connection
[Status] Needs Package Release
This is an automated check which relies on |
jeherve
changed the title
jeherve
force-pushed
the
add/auto-label-gardening-action
branch
from
bbfc8ef
to
fb5b04b
Compare
The authorize webhook is used as a fallback action for Calypso authorization flow. This PR is moving the webhook from Jetpack to `jetpack-connection`, making it available for plugins that use the package.
* Deprecate jetpack_json_wrap and migrate functionality into Sync/Functions for usage. * removal of errant comment * typo
Co-authored-by: Grant Kinney <hi@grant.mk>
…e method (#18540) * added new bridge method to sync block replacement mediaFilesBlockReplaceSync * added es-lint skip line directive
Co-authored-by: Glen Davies <glen.davies@a8c.com> Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
The general idea here is that each project should define composer commands for the different types of tests we support, and the infrastructure should just run them without doing too much that's specific to any one plugin. Thus, the PHP, JS, and Coverage workflows are rewritten to move all the Jetpack-specific stuff into Jetpack, and as a side effect the packages also get some changes to be more flexible than they had been previously. I also added some logic to better avoid running unnecessary tests: A change that only touches the Beta plugin, for example, probably doesn't need Jetpack's tests run. But a change that touches the Autoloader package will also need Jetpack tests to ensure that it didn't break Jetpack. I punted for now on the E2E tests. They're done in their own weirdly complicated way so it'll take more work to figure out which parts can be made generic, which are Jetpack-specific, and which if any we might be able to get rid of entirely.
- The new package - JS building configuration - Handy yarn commands - The WP admin menu link The new commands (run from `packages/connection-ui/` directory): - `yarn build` - `yarn watch` The Jetpack command `yarn build-packages` was also edited to also build the Connection UI package.
…ack versions (#18662) Co-authored-by: Brandon Kraft <public@brandonkraft.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
github-actions
bot
added
[Package] Assets
[Package] Autoloader
[Package] Blocks
[Package] Codesniffer
[Package] Compat
[Package] Connection
[Package] Constants
[Package] Error
[Package] Heartbeat
[Package] Jitm
[Package] Licensing
[Package] Logo
[Package] Partner
[Package] Redirect
[Package] Roles
[Package] Status
[Package] Sync
[Package] Tracking
[Plugin] Beta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge, just check the labels applied to this PR.