-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search: Fix race condition for API responses #19477
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
projects/plugins/jetpack/modules/search/instant-search/store/actions.js
Outdated
Show resolved
Hide resolved
projects/plugins/jetpack/modules/search/instant-search/store/effects.js
Outdated
Show resolved
Hide resolved
projects/plugins/jetpack/modules/search/instant-search/store/test/reducer.test.js
Show resolved
Hide resolved
projects/plugins/jetpack/modules/search/instant-search/components/search-app.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Tests out well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests well for me. 🚢
Great news! One last step: head over to your WordPress.com diff, D59942-code, and commit it. Thank you! |
🚢 r224082-wpcom |
Changes proposed in this Pull Request:
Currently, it's possible for stale API responses to overwrite newer API responses. As a fix, this PR makes two changes:
getResults
denounce from being flushed upon SearchApp mounting.Does this pull request change what data or activity we track or use?
No.
Testing instructions:
?s=apples
).