Update the instagram embed #2003
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add alternate username-based URL format handler for instagram embed and shortcode * Remove no longer needed fallback for older format embeds * Fix a typo for the comment returned when there is no embed found * Adjust the way the instagram script is loaded/fired so that it works with infinite scroll -- this adds a new js file that is enqueued properly (and thus compatible with infinite scroll) and detects IS loads and fires the appropriate instagram function to reprocess any images on the page
kraftbj
added
the
[Status] Needs Review
kraftbj
added
the
[Type] Enhancement
jkudish
added a commit
that referenced
this pull request
Apr 21, 2015
Adjust the way the facebook script is loaded/fired so that it works with infinite scroll -- this adds a new js file that is enqueued properly (and thus compatible with infinite scroll) and detects IS loads and fires the appropriate facebook function to reprocess any embeds on the page that were loaded via IS. Similar approach to #2003 for instagram
| } | ||
|
|
||
| // there's a script in the response, which we strip on purpose since it's added above | ||
| wp_enqueue_script( 'jetpack-instagram-embed', plugins_url( 'js/instagram.js', __FILE__ ), array( 'jquery' ) ); |
There was a problem hiding this comment.
Please consider updating this enqueue to wp_enqueue_script( 'jetpack-instagram-embed', plugins_url( 'js/instagram.js', __FILE__ ), array( 'jquery' ), 1.0, true ); to ensure that it is loaded at the end of the page. The script specifically relies on the <body> tag being present, so it makes sense to specify that it is loaded in the footer to prevent it from being loaded early.
There was a problem hiding this comment.
Yeah we updated this on the WP.com side, and I've now updated this PR as well. Thanks for reviewing this.
prevents js errors with loading things before the main content is ready
Instagram Shortcode: Don't bother trying to validate the URL because this is no different than doing [embed]URL[/embed] and the WP_Embed class will take care of verifying the URL as being valid. If it's not, it'll just return a clickable URL. Props @Viper007Bond
|
merged in with cbc53d4 |
dereksmart
removed
[Status] In Progress
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This syncs the instagram integration from WordPress.com to Jetpack with some changes I did over the last 3 days:
Note that this last bit adds a new file
shortcodes/js/instagram.jswhich has a corresponding file on WordPress.com and will need to be added to the build script as per @dereksmart's instructions :)