Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RNA: Components package #20148

Merged
merged 6 commits into from
Jun 24, 2021
Merged

RNA: Components package #20148

merged 6 commits into from
Jun 24, 2021

Conversation

sergeymitr
Copy link
Contributor

@sergeymitr sergeymitr commented Jun 23, 2021 •
edited
Loading

Changes proposed in this Pull Request:

  • The RNA Components package initial structure
  • Moving the JetpackLogo component from Jetpack to the RNA Components package

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  1. Rebuild Jetpack: jetpack build plugins/jetpack.
  2. Go to Jetpack Dashboard and confirm that you see the Jetpack logo in the top left corner.
  3. Rebuild Connection UI: jetpack build packages/connection-ui.
  4. Go to "Tools -> Connection Manager" and confirm that you see the Jetpack logo in the top left corner.

@sergeymitr sergeymitr added this to the jetpack/9.9 milestone Jun 23, 2021
@sergeymitr sergeymitr self-assigned this Jun 23, 2021
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello sergeymitr! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D63200-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added [Package] Connection UI [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Admin Page React-powered dashboard under the Jetpack menu [JS Package] Components labels Jun 23, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: July 6, 2021.
  • Scheduled code freeze: June 28, 2021.

@sergeymitr sergeymitr requested a review from fgiannar June 24, 2021 07:32
@sergeymitr sergeymitr added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Jun 24, 2021
fgiannar
fgiannar reviewed Jun 24, 2021
View reviewed changes
Copy link
Contributor

@fgiannar fgiannar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I test this with the Backup Plugin active, I get the following Fatal upon visiting "Tools -> Connection Manager":

PHP Fatal error:  require_once(): Failed opening required '/usr/local/src/jetpack-monorepo/projects/plugins/backup/vendor/automattic/jetpack-connection-ui/src/../build/index.asset.php' (include_path='.:/usr/share/php') in /usr/local/src/jetpack-monorepo/projects/plugins/backup/vendor/automattic/jetpack-connection-ui/src/class-admin.php on line 61

fgiannar
fgiannar approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@fgiannar fgiannar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergeymitr I tested again on a JN site and seems the initial fatal I reported only occurs on my local env.
So this should be good to go 🚢 !

@fgiannar
Copy link
Contributor

When I test this with the Backup Plugin active, I get the following Fatal upon visiting "Tools -> Connection Manager":

PHP Fatal error:  require_once(): Failed opening required '/usr/local/src/jetpack-monorepo/projects/plugins/backup/vendor/automattic/jetpack-connection-ui/src/../build/index.asset.php' (include_path='.:/usr/share/php') in /usr/local/src/jetpack-monorepo/projects/plugins/backup/vendor/automattic/jetpack-connection-ui/src/class-admin.php on line 61

Closing the loop here:
Removing the whole vendor dir under plugins/backup/ and running jetpack build plugins/backup fixed the fatal.

@sergeymitr sergeymitr merged commit 7cab17b into master Jun 24, 2021
@sergeymitr sergeymitr deleted the add/rna-components branch June 24, 2021 12:32
@sergeymitr sergeymitr removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jun 24, 2021
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D63200-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

anomiex added a commit that referenced this pull request May 10, 2022
@anomiex
jetpack: Remove unused JS client components
e58a88a 
Did a pass over _inc/client/components looking for things that weren't
used anywhere, and found a bunch:

* components/data/query-connect-url - Last use removed in #8014
* components/data/query-connection-status - Last use removed in 62e9ab0
* components/data/query-modules - Last use removed in bfc40ad
* components/data/query-plugin-updates - Last use removed in #17003
* components/data/query-site-products - Last use removed in #21594
* components/form/* - Didn't check for last use, too many bits. But it
  looks like the `formsy-react` package many of these depended on wasn't
  even installed since #8208.
* components/inline-expand - Last use removed in #6550
* components/jetpack-dialogue - Last use removed in #16518
* components/jetpack-logo - Last use removed in #20148
* components/jetpack-termination-dialog - Last use removed in #21048
* components/module-settings/index.jsx - Last use removed in #10644
* components/module-settings/inline-module-toggle.jsx - Last use removed
  in #12118
* components/screen-reader-text - Last use removed in #18843
* components/settings - Last use removed in 26315e1, I think
* components/tags-input - Last use removed in #11772

Then there were a few more that were only used from some of the above:

* components/data/query-connected-plugins
* components/module-settings/form-components.jsx
* components/multiple-choice-question
* components/setting-toggle
@anomiex anomiex mentioned this pull request May 10, 2022
Merged
anomiex added a commit that referenced this pull request May 10, 2022
@anomiex @kraftbj
jetpack: Remove unused JS client components (#24319)
d878bee 
Did a pass over _inc/client/components looking for things that weren't
used anywhere, and found a bunch:

* components/data/query-connect-url - Last use removed in #8014
* components/data/query-connection-status - Last use removed in 62e9ab0
* components/data/query-modules - Last use removed in bfc40ad
* components/data/query-plugin-updates - Last use removed in #17003
* components/data/query-site-products - Last use removed in #21594
* components/form/* - Didn't check for last use, too many bits. But it
  looks like the `formsy-react` package many of these depended on wasn't
  even installed since #8208.
* components/inline-expand - Last use removed in #6550
* components/jetpack-dialogue - Last use removed in #16518
* components/jetpack-logo - Last use removed in #20148
* components/jetpack-termination-dialog - Last use removed in #21048
* components/module-settings/index.jsx - Last use removed in #10644
* components/module-settings/inline-module-toggle.jsx - Last use removed
  in #12118
* components/screen-reader-text - Last use removed in #18843
* components/settings - Last use removed in 26315e1, I think
* components/tags-input - Last use removed in #11772

Then there were a few more that were only used from some of the above:

* components/data/query-connected-plugins
* components/module-settings/form-components.jsx
* components/multiple-choice-question
* components/setting-toggle

Co-authored-by: Brandon Kraft <public@brandonkraft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgiannar fgiannar fgiannar approved these changes

Assignees

@sergeymitr sergeymitr

Labels
Admin Page React-powered dashboard under the Jetpack menu [JS Package] Components [Package] Connection UI [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA Touches WP.com Files
Projects
None yet
Milestone
jetpack/9.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sergeymitr @matticbot @fgiannar