-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin Page: Remove dops-components as dependency #8208
Conversation
…events for select-dropdown docs example
…events for button-group docs example
…events for chart legend
9f066ab
to
90e4eae
Compare
You hit the nail on the head with the |
I think we should look at updating the classnames to cc @MichaelArestad thoughts? |
@dereksmart Yes. Bingo. That! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well, I found no regressions. Let's get this in and tidy up the css classNames in a separate PR
Another thought -- We'll want to clean up the |
Did a pass over _inc/client/components looking for things that weren't used anywhere, and found a bunch: * components/data/query-connect-url - Last use removed in #8014 * components/data/query-connection-status - Last use removed in 62e9ab0 * components/data/query-modules - Last use removed in bfc40ad * components/data/query-plugin-updates - Last use removed in #17003 * components/data/query-site-products - Last use removed in #21594 * components/form/* - Didn't check for last use, too many bits. But it looks like the `formsy-react` package many of these depended on wasn't even installed since #8208. * components/inline-expand - Last use removed in #6550 * components/jetpack-dialogue - Last use removed in #16518 * components/jetpack-logo - Last use removed in #20148 * components/jetpack-termination-dialog - Last use removed in #21048 * components/module-settings/index.jsx - Last use removed in #10644 * components/module-settings/inline-module-toggle.jsx - Last use removed in #12118 * components/screen-reader-text - Last use removed in #18843 * components/settings - Last use removed in 26315e1, I think * components/tags-input - Last use removed in #11772 Then there were a few more that were only used from some of the above: * components/data/query-connected-plugins * components/module-settings/form-components.jsx * components/multiple-choice-question * components/setting-toggle
Did a pass over _inc/client/components looking for things that weren't used anywhere, and found a bunch: * components/data/query-connect-url - Last use removed in #8014 * components/data/query-connection-status - Last use removed in 62e9ab0 * components/data/query-modules - Last use removed in bfc40ad * components/data/query-plugin-updates - Last use removed in #17003 * components/data/query-site-products - Last use removed in #21594 * components/form/* - Didn't check for last use, too many bits. But it looks like the `formsy-react` package many of these depended on wasn't even installed since #8208. * components/inline-expand - Last use removed in #6550 * components/jetpack-dialogue - Last use removed in #16518 * components/jetpack-logo - Last use removed in #20148 * components/jetpack-termination-dialog - Last use removed in #21048 * components/module-settings/index.jsx - Last use removed in #10644 * components/module-settings/inline-module-toggle.jsx - Last use removed in #12118 * components/screen-reader-text - Last use removed in #18843 * components/settings - Last use removed in 26315e1, I think * components/tags-input - Last use removed in #11772 Then there were a few more that were only used from some of the above: * components/data/query-connected-plugins * components/module-settings/form-components.jsx * components/multiple-choice-question * components/setting-toggle Co-authored-by: Brandon Kraft <public@brandonkraft.com>
These tests were all copied into the repo in #8208 as part of a large import of code from dops-components. It seems that the testing infrastructure was never configured to actually run them, and in several cases necessary supporting files were never copied in. At this point, 5 years later, it's more likely that someone should rewrite them from scratch instead of trying to fix these.
These tests were all copied into the repo in #8208 as part of a large import of code from dops-components. It seems that the testing infrastructure was never configured to actually run them, and in several cases necessary supporting files were never copied in. At this point, 5 years later, it's more likely that someone should rewrite them from scratch instead of trying to fix these.
These tests were all copied into the repo in #8208 as part of a large import of code from dops-components. It seems that the testing infrastructure was never configured to actually run them, and in several cases necessary supporting files were never copied in. At this point, 5 years later, it's more likely that someone should rewrite them from scratch instead of trying to fix these.
These tests were all copied into the repo in #8208 as part of a large import of code from dops-components. It seems that the testing infrastructure was never configured to actually run them, and in several cases necessary supporting files were never copied in. At this point, 5 years later, it's more likely that someone should rewrite them from scratch instead of trying to fix these.
Brings in all the components, mixins, scss, libraries and dependencies that the Admin Page has been using so far from dops-components.
Current status: Everything builds properly. It's a proposal of course.
Changes proposed in this Pull Request:
_inc/client/components
._inc/client/scss
._inc/client/mixins
._inc/client/lib
.Testing instructions:
yarn test-client
.yarn linst
. Expect no errors.yarn distclean && yarn clean-client && yarn cache clean && yarn build
.watch
task works:yarn watch
and the Admin page loads properly.Why