Refresh the site's modules and settings after successful product activation

[rcanepa]

Fixes 1201096622142517-as-1201431693192886

Changes proposed in this Pull Request:

• Adds a call to fetchModules and fetchSettings after successful activation of a product. We need these calls to provide a consistent UX that is aligned with the user's expectations. For example, after a user purchases Jetpack Complete, they will expect to have the search feature enabled and working. Without these calls, the user would have to refresh the page to see that. This PR prevents that.

Note: there is a known issue that affects the activation of Jetpack Complete. Particularly, the request to activate the license times out. You can bypass that by increasing the timeout from 10 to 20-30 seconds in the projects/packages/connection/src/class-client.php file (line 82).

Jetpack product discussion

• Project Thread: p1HpG7-cSg-p2

Does this pull request change what data or activity we track or use?

• Not at all.

Testing instructions:

• Spin up a site using this Jetpack branch.
• Connect Jetpack to your A8C WordPress.com account.
• Enable the A8c Proxy.
• Go to https://cloud.jetpack.com/pricing.
• Select Jetpack Complete.
• Complete checkout.
• On the "Thank you for purchase!" page, just stop there.. (Don't enter a site URL in the input box).
• On your site, visit /wp-admin/admin.php?page=jetpack#/license/activation.
• Enter the license key associated with your Jetpack Complete purchase (you can get it from SA).
• Activate the product.
• Once the activation finishes, do not refresh the page.
• Click on Jetpack > Dashboard (sidebar).
• Click on the My Plan tab.
• Verify that you see Jetpack Complete in the My Plan section.
• Verify that you see Instant search and filtering card just below that.
• Go to Jetpack > Settings (sidebar).
• Click on the Performace tab.
• Verify that Search and Instant Search Experience are enabled.

JetpackCompleteActivation.mp4

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

---

Jetpack plugin:

• Next scheduled release: December 7, 2021.
• Scheduled code freeze: November 30, 2021.

[elliottprogrammer]

Yes this works as expected. Jetpack Complete shows as the active plan and Instant search and filtering is enabled (automatically, without refreshing the page) after activating the Jetpack Complete license.
LGTM! 👍

[oskosk]

Tried to review this PR by launching two JN sites... I had the following issue both times so could't continue testing.

• First, from the testing steps, I didn't get the "Thank you for purchasing [product-name]!" page but continued with the next testing step.
• Then, I wasn't able to validate the license. Both times I got Unable to validate license.
  

One observation about the sent email

In the license form we specify that we send an email with the license. For the first site I didn't get such email.. I did get one other email about the goodies of the Complete plan...
For the second site, I did get the mail message with the license.

[rcanepa]

Tried to review this PR by launching two JN sites... I had the following issue both times so could't continue testing.

It will be hard to test these changes with a JN site due to the reason explained in the PR's description (TL;DR: the request for activating Jetpack Complete times out). If you test it locally, you can hardcode a bigger timeout (say, to 20 seconds) and make it work. Another option is to apply D70690-code to your sandbox and make your JN site rely on it. That small patch should make the activation go faster.

• First, from the testing steps, I didn't get the "Thank you for purchasing [product-name]!" page but continued with the next testing step.

Good catch. I fixed the instruction.

• Then, I wasn't able to validate the license. Both times I got Unable to validate license.

This is the result of the request failing due to the timeout.

One observation about the sent email

In the license form we specify that we send an email with the license. For the first site I didn't get such email.. I did get one other email about the goodies of the Complete plan... For the second site, I did get the mail message with the license.

Thanks for pointing this out. We will take care of investigating this issue.