Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: Update filesystem check #24884

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

leogermani
Copy link
Contributor

@leogermani leogermani commented Jun 29, 2022

Reconstructed after #24780

Fixes #22982

This PR explores how to handle the situations in which we are not able to automatically install a plugin for the user.

The proposal is to:

  • Disable the button
  • Add a notice above the button with a link to the plugin on the .org repository

Captura de tela de 2022-06-24 10-27-32

Another option I considered was to use the Notice core component, but it didn't fit in very well on a first try:

Captura de tela de 2022-06-17 18-35-15

What do you think?

Changes proposed in this Pull Request:

  • Display an alert when we can't install the plugin for the user

Jetpack product discussion

1202184803119163-as-1202324040023250

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Easiest way to test this PR is by modifying the class-initializer.php file inside the my-jetpack package folder, on line 151 and make it read like:

'fileSystemWriteAccess' => 'no',
  • Go to My Jetpack
  • Click on "Add CRM" (or any other card for which you don't have the plugin installed

@leogermani leogermani added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jun 29, 2022
@leogermani leogermani self-assigned this Jun 29, 2022
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello leogermani! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D83381-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@oskosk oskosk changed the title Update/my jetpack filesystem check My Jetpack: Update filesystem check Jun 29, 2022
oskosk
oskosk previously approved these changes Jun 29, 2022
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well!

@leogermani leogermani merged commit c031558 into trunk Jun 30, 2022
@leogermani leogermani deleted the update/my-jetpack-filesystem-check branch June 30, 2022 12:10
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jun 30, 2022
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D83381-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your SVN changeset ID (e.g. r12345-wpcom).

Thank you!

@leogermani
Copy link
Contributor Author

r248257-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My Jetpack: Handle manually install for plugins
3 participants