-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Jetpack: Update filesystem check #24884
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well!
Great news! One last step: head over to your WordPress.com diff, D83381-code, and deploy it. Thank you! |
r248257-wpcom |
Reconstructed after #24780
Fixes #22982
This PR explores how to handle the situations in which we are not able to automatically install a plugin for the user.
The proposal is to:
Another option I considered was to use the
Notice
core component, but it didn't fit in very well on a first try:What do you think?
Changes proposed in this Pull Request:
Jetpack product discussion
1202184803119163-as-1202324040023250
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Easiest way to test this PR is by modifying the
class-initializer.php
file inside the my-jetpack package folder, on line 151 and make it read like: