-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect: Handle unavailable scan status #27408
Protect: Handle unavailable scan status #27408
Conversation
…tpack's Jetpack_Plan class
…or handling unavailable scan status
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Protect plugin:
|
38c21e2
to
22e488b
Compare
80cb8d1
to
01f9855
Compare
01f9855
to
80cb8d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, really awesome work 👍
Lets merge this after #27355, just so this code doesn't end up in the diff of that PR.
The lock files test is failing, but we'll fix all of that up in the main project branch.
Co-authored-by: Nate Weller <nate.weller@automattic.com>
Fixes #
In a number of scenarios where we can determine with certainty that an appropriate scan level plan is present, but the scan module is not currently available (either due to a provisioning delay or an error), we are presented with an
unavailable
status that we do not yet have handling for.Changes proposed in this Pull Request:
setScanIsUnavailable
actioncheckStatus
actionrefreshStatus
action to usecheckStatus
where applicableAdminPage
component to react accordinglyOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
$status->status
tounavailable
by adding the following to line 69-70 insrc/class-status.php
(ensurejetpack watch plugins/protect
is running):status?hard_refresh=true
request is sent, followed by an additional three attempts while the in-progress screen is displayed before eventually resolving the error screensrc/class-status.php
, ensurewatch
runs, and refresh the page