Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Jetpack_Heartbeat #2938

Merged
merged 1 commit into from
Dec 28, 2015

Conversation

scotchfield
Copy link
Contributor

Some initial tests for the heartbeat class.

@kraftbj kraftbj added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from Crew. Label will be renamed soon. Unit Tests labels Oct 30, 2015
@kraftbj kraftbj added this to the 3.8.1 milestone Oct 30, 2015
@kraftbj
Copy link
Contributor

kraftbj commented Nov 12, 2015

Since ver needs bumping, but otherwise LGTM.

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Nov 14, 2015
@zinigor
Copy link
Member

zinigor commented Nov 14, 2015

Yep, what @kraftbj said! Looks good, thank you! Can be merged after bumping the since tags.

@samhotchkiss samhotchkiss modified the milestones: 3.9, 3.8.1 Nov 17, 2015
samhotchkiss added a commit that referenced this pull request Dec 28, 2015
@samhotchkiss samhotchkiss merged commit 6f503a5 into Automattic:master Dec 28, 2015
@samhotchkiss samhotchkiss removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Unit Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants