Publicize: point wp-admin users to WP.com calypso sharing page instead

[jkudish]

This PR seeks to remove the publicize connection settings from WP.com's wp-admin and instead point users to the Calypso sharing page for their site.

The code that powers the wp-admin sharing screen is considered legacy code, and is out of date with our latest Publicize connections codebase (powered by the WP.com REST API). We're taking aim at cleaning up old, less reliable code and reducing our technical debt, while offering the best user experience for users.

The XML-RPC methods will continue to be supported for the foreseeable future, even though the UI will be gone, but may be retired at some point once usage of older versions of Jetpack drops to low enough numbers.

With that in mind, it would be possible to re-create a wp-admin experience using the REST API. All of the endpoints are fully available and documented here: https://developer.wordpress.com/docs/api/#sharing

This PR is a merge of r128505-wpcom with additional removals for some JP-specific code.

To test:

• Apply PR to your Jetpack site
• Activate Publicize
• Verify that you get the screenshot above in place of the publicize settings
• Verify that the button and link take you to the expected Calypso Sharing page
• Verify that you can still add and remove publicize connections
• Verify that your added connections show up in wp-admin's Editor and Calypso Editor's as available connections
• Verify that posting a post publicizes the post as expected
• Verify that all of the above occurs without any php errors in your site's error log
• Login with a secondary user on your JP site, verify that you're still presented with this:

cc @timmyc @aduth @nylen for review

[kraftbj]

I'm afraid "recently" will become outdated pretty soon. Is there a better phrase or can we be sure to update it in, say, six months to something else?

[jkudish]

Eventually we can aim to remove this sentence all together, but yeah I see your point.

I don't want it to be too matter of fact without providing some context that this is an expected "new-ish" change.

Do you have a suggestion?

[aduth]

Could we just drop "recently" ? Still conveys improvements, but without as much of a time implication.

[nylen]

+1 to dropping "recently". Also, "publicize" should be capitalized in "to manage your publicize connections".

[dereksmart]

this is pretty awesome 👍

[dereksmart]

actually @jkudish I can't get posts to actually publicize with this patch.

edit: might be my local setup. Will look more tomorrow.

[jkudish]

edit: might be my local setup. Will look more tomorrow.

That's likely. This PR doesn't affect the actual publicizing of posts.

[dereksmart]

Yeah confirmed it's something broken with my site & publicize. Won't publicize from any branch. Others have confirmed this works.