-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks: use placeholder instead of random version in CLI template #32110
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
projects/plugins/jetpack/wp-cli-templates/block-register-php.mustache
Outdated
Show resolved
Hide resolved
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Proposed changes:
Since we have the
$$next-version$$
that can be used whenever we need to provide a version number, let's use that instead of a hardcoded version that will never be up-to-date for too long.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Not much to test here, but you could try to run
jetpack docker wp jetpack scaffold block "thing"
.