-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better handling on My Jetpack product interstitials if site already has prodcut #36570
Merged
jboland88
merged 9 commits into
trunk
from
update/redirect-from-interstitial-if-product-active
Mar 27, 2024
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e4ec516
Update product interstitials to use paid plan check, better handling …
jboland88 8ba8b2f
changelog
jboland88 46aece5
Merge branch 'trunk' into update/redirect-from-interstitial-if-produc…
jboland88 350c14e
Merge branch 'trunk' into update/redirect-from-interstitial-if-produc…
jboland88 b7fc9e0
version management
jboland88 be9be4f
Merge branch 'trunk' into update/redirect-from-interstitial-if-produc…
jboland88 968103d
Merge branch 'trunk' into update/redirect-from-interstitial-if-produc…
jboland88 989a5b1
Merge branch 'trunk' into update/redirect-from-interstitial-if-produc…
jboland88 9489e29
More version fixing
jboland88 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
projects/packages/my-jetpack/changelog/update-redirect-from-interstitial-if-product-active
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: minor | ||
Type: fixed | ||
|
||
Better handling on product interstitial pages if the site already has a paid product |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, I had to lookup what the meaning/definition of Moniker is... I never heard that term before! 😆
Anyway... makes sense. 👍