Masterbar: Copy module code to package

projects/packages/masterbar/.gitattributes

@@ -5,13 +5,17 @@ package.json      export-ignore
 
 # Files to include in the mirror repo, but excluded via gitignore
 # Remember to end all directories with `/**` to properly tag every file.
-# /src/js/example.min.js  production-include
+dist/**           production-include
 
 # Files to exclude from the mirror repo, but included in the monorepo.
 # Remember to end all directories with `/**` to properly tag every file.
 .gitignore        production-exclude
+.phpcs.dir.xml    production-exclude
+.phpcsignore      production-exclude
 changelog/**      production-exclude
 phpunit.xml.dist  production-exclude
-.phpcs.dir.xml    production-exclude
+src/**/*.css      production-exclude
+src/**/*.js       production-exclude
+src/**/*.scss     production-exclude
 tests/**          production-exclude
-.phpcsignore      production-exclude
+tools/**          production-exclude

projects/packages/masterbar/.gitignore

@@ -1,3 +1,6 @@
 vendor/
 node_modules/
 wordpress/
+
+dist/
+.cache/

projects/packages/masterbar/.phan/baseline.php

@@ -0,0 +1,28 @@
+<?php
+/**
+ * This is an automatically generated baseline for Phan issues.
+ * When Phan is invoked with --load-baseline=path/to/baseline.php,
+ * The pre-existing issues listed in this file won't be emitted.
+ *
+ * This file can be updated by invoking Phan with --save-baseline=path/to/baseline.php
+ * (can be combined with --load-baseline)
+ */
+return [
+    // # Issue statistics:
+    // PhanNoopNew : 5 occurrences
+    // PhanPluginUnreachableCode : 1 occurrence
+    // PhanTypeInstantiateAbstract : 1 occurrence
+    // PhanTypeMismatchArgument : 1 occurrence
+    // PhanTypeSuspiciousEcho : 1 occurrence
+    // PhanUndeclaredClassReference : 1 occurrence
+
+    // Currently, file_suppressions and directory_suppressions are the only supported suppressions
+    'file_suppressions' => [
+        'src/admin-menu/class-wpcom-admin-menu.php' => ['PhanTypeMismatchArgument'],
+        'src/class-main.php' => ['PhanNoopNew'],
+        'src/profile-edit/bootstrap.php' => ['PhanNoopNew'],
+        'tests/php/test-class-admin-color-schemes.php' => ['PhanNoopNew'],
+    ],
+    // 'directory_suppressions' => ['src/directory_name' => ['PhanIssueName1', 'PhanIssueName2']] can be manually added if needed.
+    // (directory_suppressions will currently be ignored by subsequent calls to --save-baseline, but may be preserved in future Phan releases)
+];

projects/packages/masterbar/.phan/config.php

@@ -10,4 +10,26 @@
 // Require base config.
 require __DIR__ . '/../../../../.phan/config.base.php';
 
-return make_phan_config( dirname( __DIR__ ) );
+// We need to load the wpcom and amp stubs too.
+return make_phan_config(
+	dirname( __DIR__ ),
+	array(
+		'+stubs'          => array( 'wpcom', 'amp' ),
+		'parse_file_list' => array(
+
+			/*
+			Reference files to handle code checking for stuff from Jetpack-the-plugin or other in-monorepo plugins.
+			 * Wherever feasible we should really clean up this sort of thing instead of adding stuff here.
+			 *
+			 * DO NOT add references to files in other packages like this! Generally packages should be listed in composer.json 'require'.
+			 * If there are truly optional dependencies or circular dependencies that can't be cleaned up, one package may list the
+			 * other in 'require-dev' and `extra.dependencies.test-only' instead. See packages/config for an example.
+			 */
+			__DIR__ . '/../../../plugins/jetpack/3rd-party/class.jetpack-amp-support.php',
+			__DIR__ . '/../../../plugins/jetpack/modules/custom-css/custom-css.php',
+			__DIR__ . '/../../../plugins/jetpack/modules/notes.php',
+			__DIR__ . '/../../../plugins/jetpack/modules/scan/class-admin-bar-notice.php',
+			__DIR__ . '/../../../plugins/jetpack/modules/stats.php',
+		),
+	)
+);

projects/packages/masterbar/README.md

@@ -1,14 +1,17 @@
-# masterbar
+# Masterbar
 
 The WordPress.com Toolbar feature replaces the default admin bar and offers quick links to the Reader, all your sites, your WordPress.com profile, and notifications.
 
-## How to install masterbar
+## Get Started 
 
-### Installation From Git Repo
+Package is published in [Packagist](https://packagist.org/packages/automattic/jetpack-masterbar). We recommend using the latest version there, or you can also test with the latest development versions like below:
 
-## Contribute
-
-## Get Help
+```
+"require": {
+    "automattic/jetpack-autoloader": "dev-trunk",
+    "automattic/jetpack-masterbar": "dev-trunk"
+}
+```
 
 ## Using this package in your WordPress plugin
 
@@ -18,7 +21,19 @@ If you plan on using this package in your WordPress plugin, we would recommend t
 
 Need to report a security vulnerability? Go to [https://automattic.com/security/](https://automattic.com/security/) or directly to our security bug bounty site [https://hackerone.com/automattic](https://hackerone.com/automattic).
 
+## Build System
+
+_Note: `cd` to `projects/packages/masterbar` before running these commands_
+
+- `npm run build`<br>
+  Compiles the plugins for development - the files are not minified and we produce a source map.
+
+- `npm run build-production`<br>
+  Compiles the plugins for production - we produce minified files without source maps.
+
+- `npm run clean`<br>
+  Removes all build files.
+
 ## License
 
 masterbar is licensed under [GNU General Public License v2 (or later)](./LICENSE.txt)
-

projects/packages/masterbar/changelog/update-copy-masterbar-code-to-pkg

@@ -0,0 +1,4 @@
+Significance: minor
+Type: changed
+
+Masterbar: Copy module code to package

projects/packages/masterbar/composer.json

@@ -4,11 +4,22 @@
 	"type": "jetpack-library",
 	"license": "GPL-2.0-or-later",
 	"require": {
-		"php": ">=7.0"
+		"php": ">=7.0",
+		"automattic/jetpack-assets": "@dev",
+		"automattic/jetpack-blaze": "@dev",
+		"automattic/jetpack-compat": "@dev",
+		"automattic/jetpack-device-detection": "@dev",
+		"automattic/jetpack-connection": "@dev",
+		"automattic/jetpack-jitm": "@dev",
+		"automattic/jetpack-logo": "@dev",
+		"automattic/jetpack-plans": "@dev",
+		"automattic/jetpack-status": "@dev"
 	},
 	"require-dev": {
+		"brain/monkey": "2.6.1",
 		"yoast/phpunit-polyfills": "1.1.0",
 		"automattic/jetpack-changelogger": "@dev",
+		"automattic/patchwork-redefine-exit": "@dev",
 		"automattic/wordbless": "dev-master"
 	},
 	"autoload": {
@@ -17,14 +28,19 @@
 		]
 	},
 	"scripts": {
-		"build-development": "echo 'Add your build step to composer.json, please!'",
-		"build-production": "echo 'Add your build step to composer.json, please!'",
+		"build-production": [
+			"pnpm run build-production"
+		],
+		"build-development": [
+			"pnpm run build"
+		],
 		"phpunit": [
 			"./vendor/phpunit/phpunit/phpunit --colors=always"
 		],
 		"post-install-cmd": "WorDBless\\Composer\\InstallDropin::copy",
 		"post-update-cmd": "WorDBless\\Composer\\InstallDropin::copy",
 		"test-php": [
+			"pnpm run build-production",
 			"@composer phpunit"
 		]
 	},
@@ -55,7 +71,7 @@
 		"mirror-repo": "Automattic/jetpack-masterbar",
 		"textdomain": "jetpack-masterbar",
 		"version-constants": {
-			"::PACKAGE_VERSION": "src/class-masterbar.php"
+			"::PACKAGE_VERSION": "src/class-main.php"
 		}
 	},
 	"suggest": {

projects/packages/masterbar/package.json

@@ -15,11 +15,34 @@
 	"license": "GPL-2.0-or-later",
 	"author": "Automattic",
 	"scripts": {
-		"build": "echo 'Not implemented.'",
-		"build-js": "echo 'Not implemented.'",
-		"build-production": "echo 'Not implemented.'",
-		"build-production-js": "echo 'Not implemented.'",
-		"clean": "true"
+		"build": "pnpm run clean && pnpm run build-js",
+		"build-js": "webpack --config tools/webpack.config.js",
+		"build-production": "pnpm run clean && pnpm run build-production-js && pnpm run validate",
+		"build-production-js": "NODE_ENV=production BABEL_ENV=production pnpm run build-js",
+		"clean": "rm -rf dist/ .cache/",
+		"validate": "pnpm exec validate-es --no-error-on-unmatched-pattern dist/",
+		"watch": "pnpm run build && pnpm webpack watch"
 	},
-	"devDependencies": {}
+	"dependencies": {
+		"@automattic/calypso-color-schemes": "3.1.3",
+		"@automattic/color-studio": "2.6.0",
+		"postcss-custom-properties": "12.1.7"
+	},
+	"devDependencies": {
+		"@automattic/jetpack-webpack-config": "workspace:*",
+		"@automattic/remove-asset-webpack-plugin": "workspace:*",
+		"autoprefixer": "10.4.14",
+		"@csstools/postcss-global-data": "2.1.1",
+		"@babel/core": "7.24.0",
+		"@wordpress/browserslist-config": "5.39.0",
+		"@wordpress/dependency-extraction-webpack-plugin": "5.7.0",
+		"core-js": "3.23.5",
+		"glob": "10.3.15",
+		"postcss": "8.4.31",
+		"postcss-loader": "6.2.0",
+		"sass": "1.64.1",
+		"sass-loader": "12.4.0",
+		"webpack": "5.76.0",
+		"webpack-cli": "4.9.1"
+	}
 }