-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Masterbar: Copy module code to package #37342
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
projects/packages/masterbar/src/nudges/additional-css/js/additional-css.js
Fixed
Show fixed
Hide fixed
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
@Automattic/jetpack-vulcan How do we usually handle the ESLint failing tests related to missing JSDoc elements? Should I manually fix those or add an ignore rule? |
I've not looked through the full list of phan flagged issues, but certainly some look like false positives, eg |
@darssen Many thanks for the review! Really appreciate the time you took!
I believe these are all addressed now. I've also left responses to all your inline comments!
Amazing thanks! Done with a2b5a0f Would you mind giving this a final look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the changes. Code looks good 👍
We can 🚢 this one, since most of the testing will be done once we actually start using the package.
We need to remember to keep an eye on future changes in the module before we start using the package.
@anomiex Since you were also involved in this PR would you mind giving it a final check too? Many thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left some suggestions inline for further improvement, but I'd be fine with merging this and iterating.
Note I mainly looked at the structure, I didn't look through the code.
@@ -5,7 +5,7 @@ package.json export-ignore | |||
|
|||
# Files to include in the mirror repo, but excluded via gitignore | |||
# Remember to end all directories with `/**` to properly tag every file. | |||
# /src/js/example.min.js production-include | |||
dist/** production-include | |||
|
|||
# Files to exclude from the mirror repo, but included in the monorepo. | |||
# Remember to end all directories with `/**` to properly tag every file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional stuff you might production-exclude
here:
tools/**
- Probably also
src/**/*.scss
andsrc/**/*.css
andsrc/**/*.js
, since they're all compiled into JS indist/
now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done via 8265d6c
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Thanks @anomiex ! I wanted to update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, haven't tested though.
All the test failures are unrelated. Chances are a trunk merge after #37659 is merged will be needed for those.
This PR copies the Masterbar module codebase to the
masterbar
package. In the process:Jetpack::is_module_active
has been replaced by( new Modules() )->is_module_active
JETPACK__VERSION
used for cache busting when enqueueing scripts and styles is now replaced byMain::PACKAGE_VERSION
jetpack-masterbar
fromjetpack
rtl
files are now generated with a custom config (we used to refer to them as weird RTL entries because-rtl
was appended instead of.rtl
) and the corresponding code references as well.dist
folderAssets
packageOther information:
Jetpack product discussion
pfwV0U-3U-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions:
jetpack build packages/masterbar
with/without--production
and inspect the generated assets in thedist
folder