Social: Add connection management tests #37516
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
gmjuhasz
changed the title
| @@ -27,5 +28,5 @@ export function ConnectionName( { connection }: ConnectionNameProps ) { | |||
| </div> | |||
| ); | |||
| } | |||
| return <Spinner color="black" />; | |||
| return <Spinner color="black" aria-label={ __( 'Loading spinner', 'jetpack' ) } />; | |||
There was a problem hiding this comment.
I think this is no longer used now.
There was a problem hiding this comment.
If we still need it, then the label can be something like "Loading/Fetching account details"
There was a problem hiding this comment.
I updated this for now as you suggested, we can get rid of it when we remove the functionality from the actual code 👍
...packages/publicize-components/src/components/connection-management/tests/specs/index.test.js
Show resolved
Hide resolved
| /> | ||
| ); | ||
|
|
||
| const toggle = screen.getByRole( 'checkbox', { name: 'Mark the connection as shared' } ); |
There was a problem hiding this comment.
TIL that name here targets the label.
Fixes https://github.com/Automattic/jetpack-reach/issues/360
Proposed changes:
Other information:
Jetpack product discussion
https://github.com/Automattic/jetpack-reach/issues/360
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Go to the publicize components folder
projects/js-packages/publicize-componentsRun tests with
pnpm run testConnectionStatus
✓ renders nothing when connection status is "ok" (19 ms)
✓ renders nothing when connection status is undefined (2 ms)
✓ renders the appropriate notice and Reconnect component when connection status is not "ok" or undefined (4 ms)
✓ renders the correct notice when connection status is "refresh-failed" (2 ms)
Reconnect
✓ renders the Reconnect button with correct label (35 ms)
✓ disables the button when isDisconnecting is true (9 ms)
✓ calls deleteConnectionById and requestAccess on button click (23 ms)
✓ does not render the button if connection cannot be disconnected (2 ms)
Marking a connection as shared
✓ toggling the checkbox should mark a connection as shared (135 ms)
✓ toggle is disabled while updating (8 ms)
Disconnecting a connection
✓ disconnecting a connection should call the disconnect method (200 ms)
✓ panel is disabled while updating (11 ms)
✓ button changes name and is disabled while updating (8 ms)
ConnectionManagement
No connections
✓ renders the component with no connections (43 ms)
With connections
✓ renders the spinner without connection name (36 ms)
✓ renders the component with proper connections (13 ms)
Connection panel
✓ connection panel can be opened and closed (111 ms)
✓ clicking disconnect should bring up confirmation which can be cancelled (96 ms)
✓ mark as shared component is visible if user has permission (43 ms)