-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map Block: React 19 compatibility - converting defaultProps usage on MapkitComponent #38274
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-hosted
I tested using the provided instructions and it works as expected!
I created a post with a Map block and made sure to set all the corresponding block settings.
I then switched to this branch and ensured nothing had changed on both the post page and when editing the post.
I then created another post with a map and changed all the Map block settings in the editor.
It worked as expected and all my changes were also reflected in the corresponding post's page.
No relevant errors in the web console as well.
Simple
Though it works as expected overall, in some cases (could not consistently reproduce) I could not see the map block editor, when clicking on the corresponding Map block. Is this something you can also reproduce perhaps?
![Screenshot 2024-07-10 at 13 09 55](https://private-user-images.githubusercontent.com/1758399/347358917-36c53deb-42bc-481d-bdfe-08558bdbeca2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwMjk3MzMsIm5iZiI6MTcyNjAyOTQzMywicGF0aCI6Ii8xNzU4Mzk5LzM0NzM1ODkxNy0zNmM1M2RlYi00MmJjLTQ4MWQtYmRmZS0wODU1OGJkYmVjYTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTFUMDQzNzEzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTFlZDc0YzlkMGFiNmY1MzY5MjA2ZWM4M2Q1MDM4ZTEwNjcxNTRmOTFiOTBkZWUwOTgzN2JlZTYxMTIwNWY1NiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.yN7r3Dp5vXbWzXji7mKLGK7dpr8QErfOpb8dteQTI_A)
Thanks for testing!
Yes, it was, but it was the same without the changes from this PR. I went to create an issue earlier (if I'm understanding that your issue was the same as mine), but there is one already which I added to the Vulcan backlog: #31870 I noticed that issue on Simple and Atomic, I couldn't reproduce on self-hosted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it was, but it was the same without the changes from this PR. I went to create an issue earlier (if I'm understanding that your issue was the same as mine), but there is one already which I added to the Vulcan backlog: #31870
Excellent 👍 Approving then 🚢
Partial fix to #38271
Proposed changes:
Other information:
Jetpack product discussion
#38271
Does this pull request change what data or activity we track or use?
No.
Testing instructions: