-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jetpack: Fix undefined array warnings in Donations block #38281
jetpack: Fix undefined array warnings in Donations block #38281
Conversation
If the donations block sets `oneTimeDonation`, `monthlyDonation`, and/or `annualDonation` without including a `planId` field, ensure the field is set by including the value used in the block.json in the defaults. If the `currency` attribute is not set or is invalid, and `showCustomAmount` is true, fall back to the generic currency symbol `¤` like `Jetpack_Currencies::format_price()` already does and default to ¤100. Also, `Jetpack_Currencies::format_price()` should honor its `$symbol` argument when doing that fallback.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
I don't see anything in #17381 that discusses this behavior. It's possible it was an accidental bug that wasn't noticed because of the undefined array key access producing null which produces the empty string, and that the test was a copy-paste of the previous test that didn't notice `false` being passed. I see no other uses of `Jetpack_Currencies` with `$symbol = false` in the monorepo or opengrok or wpdirectory, so this should be safe to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for working on this and adding a unit test too.
Not a blocker but I'd also consider adding ¤ as a class constant in Jetpack_Currencies
.
Proposed changes:
If the donations block sets
oneTimeDonation
,monthlyDonation
, and/orannualDonation
without including aplanId
field, ensure the field is set by including the value used in the block.json in the defaults.If the
currency
attribute is not set or is invalid, andshowCustomAmount
is true, fall back to the generic currency symbol¤
likeJetpack_Currencies::format_price()
already does and default to ¤100.Also,
Jetpack_Currencies::format_price()
should honor its$symbol
argument when doing that fallback.Other information:
Jetpack product discussion
p1720547616141829/1720546514.458029-slack-C01U2KGS2PQ
p1HpG7-tpT-p2
Does this pull request change what data or activity we track or use?
Testing instructions:
<!-- wp:jetpack/donations {"oneTimeDonation":{"show":true,"amounts":[5,15,100]}} /-->
as a block, and save without going back to the visual editor.