Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4309 - flickr shortcode: size parameter not used anywhere #4311

Closed
wants to merge 1 commit into from

Conversation

bobbingwide
Copy link
Contributor

@bobbingwide bobbingwide commented Jul 6, 2016

Fixes #4309 .

Changes proposed in this Pull Request:

Delete the line containing the only instance of 'size'

I don't see the need to change any test cases.


@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Shortcodes / Embeds [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jul 6, 2016
@jeherve jeherve added this to the 4.2 milestone Jul 6, 2016
@enejb enejb added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jul 12, 2016
@enejb
Copy link
Member

enejb commented Jul 12, 2016

This make sense to me.
I don't think we ever implemented the size parameter.

@enejb
Copy link
Member

enejb commented Jul 12, 2016

This PR needs to be rebased in order for us to merge it.

@jeherve jeherve added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jul 13, 2016
@jeherve jeherve modified the milestones: 4.3, 4.2 Jul 22, 2016
@richardmuscat richardmuscat modified the milestones: 4.3, 4.3.1 Jul 26, 2016
@samhotchkiss samhotchkiss modified the milestones: 4.3.2, 4.3.1 Sep 2, 2016
@dereksmart dereksmart modified the milestones: 4.3.1, 4.3.2 Sep 6, 2016
@samhotchkiss samhotchkiss removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 11, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Shortcodes / Embeds [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants