Mobile theme: remove unused option that prevented it from loading

[eliorivero]

Fixes p1HpG7-3s1-p2

Changes proposed in this Pull Request:

• Removes the option wp_mobile_disable and an associated filter option_wp_mobile_disable that prevented it from loading.

Testing instructions:

• Activate mobile theme
• Visit the site in desktop, it should use the regular theme
• Visit the site in mobile, it should use the Minileven mobile theme

[kraftbj]

Introduced in ad38724 via #4281 by autoloading the option, which was previously not set.

If we ever trying to sync up minileven between Jetpack and WP.com (ignored in the build script since r97888-wpcom / 2014), we'll run into problems since on WP.com, you can disable the mobile theme (since this runs as a mu-plugin there).

That said, since we haven't been syncing it and my guess that we'll care less and less about the mobile theme given responsive theming, probably safe.

cc: @gravityrail

[kraftbj]

In addition to straight removing this, should we clean up after ourselves and delete wp_mobile_disable since it'll be set on all 4.2 sites?

[eliorivero]

I wouldn't. In sites < 4.2 this option wouldn't even be set. In sites >= 4.2, it's neglectable. The thing is that we would have to add some checking to see if the option was created or not and delete it, and don't want to add more processing time to clean up something so small.

[jeherve]

Also reported here:
https://wordpress.org/support/topic/mobile-theme-not-working-4?replies=5

[eliorivero]

@kraftbj thanks for the feedback. I've changed this PR and decided to add the filter only in wpcom so in this way the feature continues to work normally in the plugin version and we're covered if we ever sync this file back to wpcom. I think we're good to go after this but can you please review it?

[kraftbj]

Looking at the build script, the files within /modules/minileven are commented out, but modules/minileven.php isn't mentioned at all. I think we're safe to remove it from that file completely, but no harm in the conditional either.

[annezazuu]

mentioned in 2783445-t, 2783483-t, 2783582-t , 2782687-t

[scarstocea]

Mentioned in 2782854-t.