Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Script: npm install before production build #4966

Merged
merged 1 commit into from
Aug 24, 2016
Merged

Build Script: npm install before production build #4966

merged 1 commit into from
Aug 24, 2016

Conversation

dereksmart
Copy link
Member

Building the production plugin requires gulp, so let's install everything before we run production.

@dereksmart dereksmart added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from Crew. Label will be renamed soon. Admin Page React-powered dashboard under the Jetpack menu labels Aug 24, 2016
@oskosk
Copy link
Contributor

oskosk commented Aug 24, 2016

LGTM!

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Aug 24, 2016
@samhotchkiss samhotchkiss merged commit c0ab65a into master Aug 24, 2016
@samhotchkiss samhotchkiss deleted the fix/build-to-master-script branch August 24, 2016 21:47
@samhotchkiss samhotchkiss removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Admin Page React-powered dashboard under the Jetpack menu [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dereksmart @oskosk @samhotchkiss