Sync post list 1.1 endpoint. #7008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merges r134116-wpcom.
… post type Merges r138391-wpcom.
Merges r144233-wpcom.
zinigor
added
the
[Status] Needs Review
|
Master issue: #7026 |
19 tasks
jeherve
reviewed
Apr 23, 2017
| @@ -311,6 +312,13 @@ function callback( $path = '', $blog_id = 0 ) { | |||
| $return[$key]->next_page = $this->build_page_handle( $last_post, $query ); | |||
| } | |||
| } | |||
|
|
|||
| if ( defined( 'IS_WPCOM' ) && IS_WPCOM ) { | |||
| if ( !isset( $return[$key] ) ) | |||
There was a problem hiding this comment.
Should we take that opportunity to clean up that code so it respects the WP coding standards?
eliorivero
added
[Status] Ready to Merge
eliorivero
reviewed
Apr 24, 2017
| if ( defined( 'IS_WPCOM' ) && IS_WPCOM ) { | ||
| if ( !isset( $return[$key] ) ) | ||
| $return[$key] = new stdClass; | ||
| $return[$key]->wpcom = true; |
There was a problem hiding this comment.
Although it's not a blocker @zinigor the spacing could be fixed in both sides.
|
Appreciate the comments, but I'd rather sync this now, and then fix spacing on a file that has a common ancestor. We'll get this all fixed! |
zinigor
removed
the
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.