Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Markdown support as a Markdown-specific Gutenberg Block #9357

Closed
wants to merge 58 commits into from
Closed

Feature: Markdown support as a Markdown-specific Gutenberg Block #9357

wants to merge 58 commits into from

Commits on Apr 26, 2018

  1. Prototype block structure and icon working 

    Initial file seed.
    @nuzzio
    nuzzio committed Apr 26, 2018
    Copy the full SHA
    f68d0fd View commit details
    Browse the repository at this point in the history

  2. Simplified block to use plaintext and currently saving content

    @nuzzio
    nuzzio committed Apr 26, 2018
    Copy the full SHA
    a6bfb98 View commit details
    Browse the repository at this point in the history

  3. matched current color for gutenberg icons

    @nuzzio
    nuzzio committed Apr 26, 2018
    Copy the full SHA
    5090149 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2018

  1. Prototype block structure and icon working 

    Initial file seed.
    @nuzzio
    nuzzio committed Apr 29, 2018
    Copy the full SHA
    3e3a2ea View commit details
    Browse the repository at this point in the history

  2. Simplified block to use plaintext and currently saving content

    @nuzzio
    nuzzio committed Apr 29, 2018
    Copy the full SHA
    1014ff9 View commit details
    Browse the repository at this point in the history

  3. matched current color for gutenberg icons

    @nuzzio
    nuzzio committed Apr 29, 2018
    Copy the full SHA
    ca238fc View commit details
    Browse the repository at this point in the history

  4. Added patterns to protect non-Markdown blocks 

    Added patterns that will attempt to preserve all  Gutenberg non-Markdown blocks from the Markdown parser.
    @nuzzio
    nuzzio committed Apr 29, 2018
    Copy the full SHA
    a1c6611 View commit details
    Browse the repository at this point in the history

  5. Remove the PlainText block wrapper 

    Remove the textarea wrapper to avoid rendering it as a textarea form element for the reader.
    @nuzzio
    nuzzio committed Apr 29, 2018
    Copy the full SHA
    2a89e36 View commit details
    Browse the repository at this point in the history

  6. Reuse markdown content on Meta Box update 

    The idea here is to reuse the existing original Markdown, on the second post for Meta Boxes following a `Save Draft` event. This way when the markdown parser runs a second time it does not parse the rendered markup in `post_content` and overwrite the original Markdown in `post_content_filtered`.
    @nuzzio
    nuzzio committed Apr 29, 2018
    Copy the full SHA
    fc58ffe View commit details
    Browse the repository at this point in the history

  7. added markdown attribute to block

    @nuzzio
    nuzzio committed Apr 29, 2018
    Copy the full SHA
    7cecd85 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'add/gutenberg-markdown-block' of https://github.com/nuz… 

    …zio/jetpack into add/gutenberg-markdown-block

# Conflicts:
#	modules/markdown/assets/js/jetpack-markdown-block.jsx
    @nuzzio
    nuzzio committed Apr 29, 2018
    Copy the full SHA
    efe24b5 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2018

  1. Added block styles to look more like the code block

    @nuzzio
    nuzzio committed May 1, 2018
    Copy the full SHA
    56e891f View commit details
    Browse the repository at this point in the history

  2. Added CSS enqueue

    @nuzzio
    nuzzio committed May 1, 2018
    Copy the full SHA
    0df47da View commit details
    Browse the repository at this point in the history

  3. Added rest_route as an additional Gutenberg check

    @nuzzio
    nuzzio committed May 1, 2018
    Copy the full SHA
    62ce3c9 View commit details
    Browse the repository at this point in the history

  4. Fixing munged left angle bracket on HTML tags

    @nuzzio
    nuzzio committed May 1, 2018
    Copy the full SHA
    f8588e9 View commit details
    Browse the repository at this point in the history

  5. Fixed HTML rendering in preview

    @nuzzio
    nuzzio committed May 1, 2018
    Copy the full SHA
    ae7537c View commit details
    Browse the repository at this point in the history

  6. removed dynamic render

    @nuzzio
    nuzzio committed May 1, 2018
    Copy the full SHA
    582e181 View commit details
    Browse the repository at this point in the history

  7. Adjusted filter params and added removal

    @nuzzio
    nuzzio committed May 1, 2018
    Copy the full SHA
    3269125 View commit details
    Browse the repository at this point in the history

  8. Moved angle bracket fix to the_content filter

    @nuzzio
    nuzzio committed May 1, 2018
    Copy the full SHA
    0831bfd View commit details
    Browse the repository at this point in the history

  9. Added reference to specification failiure

    @nuzzio
    nuzzio committed May 1, 2018
    Copy the full SHA
    e34a112 View commit details
    Browse the repository at this point in the history

  10. pruned unused variable

    @nuzzio
    nuzzio committed May 1, 2018
    Copy the full SHA
    6687808 View commit details
    Browse the repository at this point in the history

  11. Meeting Markdown spec 

    so that Markdown formatting syntax is not processed within block-level HTML
    @nuzzio
    nuzzio committed May 1, 2018
    Copy the full SHA
    0e3d80b View commit details
    Browse the repository at this point in the history

  12. Removed extra parameter on remove filter

    @nuzzio
    nuzzio committed May 1, 2018
    Copy the full SHA
    862898f View commit details
    Browse the repository at this point in the history

  13. Added filter call for Gutenberg edit post 

    apply filter is located in wp-content/plugins/gutenberg/lib/client-assets.php line 841
    @nuzzio
    nuzzio committed May 1, 2018
    Copy the full SHA
    fd28b19 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2018

  1. Check if Gutenberg is loaded 

    do this prior to attempting block registration.
    @nuzzio
    nuzzio committed May 2, 2018
    Copy the full SHA
    933ea87 View commit details
    Browse the repository at this point in the history

  2. Simplified textarea save format 

    Using a textarea preserves the newlines in the input field faithfully on the POST. These are caught by the `strip_gutenberg_text_area_wrapper` to remove the node for the user side and introduce additional newlines for proper formatting.
    @nuzzio
    nuzzio committed May 2, 2018
    Copy the full SHA
    eff948e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into add/gutenberg-markdown-block

    @nuzzio
    nuzzio committed May 2, 2018
    Copy the full SHA
    e753704 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2018

  1. Fixed function to reflect proper inputs after refactor

    @nuzzio
    nuzzio committed May 3, 2018
    Copy the full SHA
    d8bf411 View commit details
    Browse the repository at this point in the history

  2. added after_gutenberg_gets_post_to_edit and fixed spacing

    @nuzzio
    nuzzio committed May 3, 2018
    Copy the full SHA
    0e1cd99 View commit details
    Browse the repository at this point in the history

  3. Cleaned up comment

    @nuzzio
    nuzzio committed May 3, 2018
    Copy the full SHA
    d74cab4 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2018

  1. Merge branch 'master' of https://github.com/Automattic/jetpack into a… 

    …dd/gutenberg-markdown-block
    @nuzzio
    nuzzio committed May 12, 2018
    Copy the full SHA
    20a00ee View commit details
    Browse the repository at this point in the history

  2. fixed comments

    @nuzzio
    nuzzio committed May 12, 2018
    Copy the full SHA
    c4cac44 View commit details
    Browse the repository at this point in the history

  3. added gutenberg test

    @nuzzio
    nuzzio committed May 12, 2018
    Copy the full SHA
    497bdb6 View commit details
    Browse the repository at this point in the history

  4. added tests for markdown block rendering

    @nuzzio
    nuzzio committed May 12, 2018
    Copy the full SHA
    1034d39 View commit details
    Browse the repository at this point in the history

  5. fixed method name

    @nuzzio
    nuzzio committed May 12, 2018
    Copy the full SHA
    11faa06 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2018

  1. Refactored tests and added fixtures

    @nuzzio
    nuzzio committed May 14, 2018
    Copy the full SHA
    60573a7 View commit details
    Browse the repository at this point in the history

  2. added markdown testsuite

    @nuzzio
    nuzzio committed May 14, 2018
    Copy the full SHA
    5ee1320 View commit details
    Browse the repository at this point in the history

  3. converted to legacy array declaration

    @nuzzio
    nuzzio committed May 14, 2018
    Copy the full SHA
    0507d3d View commit details
    Browse the repository at this point in the history

  4. Updated markdown block description

    @nuzzio
    nuzzio committed May 14, 2018
    Copy the full SHA
    4460e2b View commit details
    Browse the repository at this point in the history

  5. Added compatibility flag for Gutenberg

    @nuzzio
    nuzzio committed May 14, 2018
    Copy the full SHA
    cd931dd View commit details
    Browse the repository at this point in the history

  6. Fixed code style.

    @nuzzio
    nuzzio committed May 14, 2018
    Copy the full SHA
    25bd848 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2018

  1. serializing pre tag instead of textarea

    @nuzzio
    nuzzio committed May 17, 2018
    Copy the full SHA
    f7c6317 View commit details
    Browse the repository at this point in the history

  2. Added variables for block tags

    @nuzzio
    nuzzio committed May 17, 2018
    Copy the full SHA
    6c31407 View commit details
    Browse the repository at this point in the history

  3. Simplified and commented regex

    @nuzzio
    nuzzio committed May 17, 2018
    Copy the full SHA
    5b5ce51 View commit details
    Browse the repository at this point in the history

  4. Resolved todo

    @nuzzio
    nuzzio committed May 17, 2018
    Copy the full SHA
    aad6c1e View commit details
    Browse the repository at this point in the history

  5. Used block tag variables, simplified block regex

    @nuzzio
    nuzzio committed May 17, 2018
    Copy the full SHA
    9ba9a94 View commit details
    Browse the repository at this point in the history

  6. Updated test to reflect pre wrapper

    @nuzzio
    nuzzio committed May 17, 2018
    Copy the full SHA
    9f64993 View commit details
    Browse the repository at this point in the history

  7. Removed unnecessary function and cleaned comments

    @nuzzio
    nuzzio committed May 17, 2018
    Copy the full SHA
    ec82a05 View commit details
    Browse the repository at this point in the history

  8. Cleaned up comments

    @nuzzio
    nuzzio committed May 17, 2018
    Copy the full SHA
    68f44fd View commit details
    Browse the repository at this point in the history

Commits on May 19, 2018

  1. cleaned up comment

    @nuzzio
    nuzzio committed May 19, 2018
    Copy the full SHA
    bdd722e View commit details
    Browse the repository at this point in the history

  2. removed old comment

    @nuzzio
    nuzzio committed May 19, 2018
    Copy the full SHA
    192640b View commit details
    Browse the repository at this point in the history

  3. clarified wautop usage

    @nuzzio
    nuzzio committed May 19, 2018
    Copy the full SHA
    21dfd0a View commit details
    Browse the repository at this point in the history

  4. Worpress formatting checks

    @nuzzio
    nuzzio committed May 19, 2018
    Copy the full SHA
    4d3a8f9 View commit details
    Browse the repository at this point in the history

  5. Updated function names to reflect generic wrapper

    @nuzzio
    nuzzio committed May 19, 2018
    Copy the full SHA
    f4f4828 View commit details
    Browse the repository at this point in the history

  6. Capitalized Markdown

    @nuzzio
    nuzzio committed May 19, 2018
    Copy the full SHA
    e30ff63 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2018

  1. replaced gutenberg references with block_editor

    @nuzzio
    nuzzio committed May 24, 2018
    Copy the full SHA
    8860e80 View commit details
    Browse the repository at this point in the history

  2. changed gutenberg filename to block-editor

    @nuzzio
    nuzzio committed May 24, 2018
    Copy the full SHA
    4238168 View commit details
    Browse the repository at this point in the history

  3. changed gutenberg name to block editor in tests

    @nuzzio
    nuzzio committed May 24, 2018
    Copy the full SHA
    4c3b5b2 View commit details
    Browse the repository at this point in the history