-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy Images: Do not change image display for no JS support #9872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebinnion
added
[Type] Bug
When a feature is broken and / or not performing as intended
[Status] Needs Review
To request a review from Crew. Label will be renamed soon.
[Feature] Lazy Images
labels
Jul 5, 2018
Generated by 🚫 dangerJS |
ebinnion
force-pushed
the
update/lazy-images-no-js-css-fix
branch
from
July 5, 2018 19:43
246952c
to
b9f95c6
Compare
ebinnion
changed the title
Lazy Images: Set display to block when showing lazy images
Lazy Images
Jul 5, 2018
ebinnion
changed the title
Lazy Images
Lazy Images: Do not change image display for no JS support
Jul 5, 2018
brbrr
approved these changes
Jul 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on both desktop & mobile screensizes
LGTM 🚢
brbrr
added
[Status] Ready to Merge
Go ahead, you can push that green button!
and removed
[Status] Needs Review
To request a review from Crew. Label will be renamed soon.
labels
Jul 9, 2018
ghost
removed
the
[Status] Ready to Merge
Go ahead, you can push that green button!
label
Jul 9, 2018
oskosk
pushed a commit
that referenced
this pull request
Jul 31, 2018
oskosk
added a commit
that referenced
this pull request
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support browsers without JavaScript enabled, we made a change to hide lazily loaded images by default and then add a class with JavaScript which would show the lazy loaded image. This was done in #9780.
When released, at least two users reported issues with their images no longer being centered. This is because we were setting the display to
inline-block
when we decided to show the image. This PR changes that behavior so that we set display toblock
instead.Ideally, we would hide the lazily loaded images by appending a class to the HTML element when the post is rendered. Then, we could just remove the class with JavaScript. That being said, I am not aware of a great way to do this in WordPress.I just pushed a second commit to do just that. Essentially, I use anot
selector on thehtml
element to hide the image, and then use JavaScript to set the class on thehtml
element which will show the lazy loaded image.To test:
Before:
After:
Fixes: #9879