Fix css-file read in windows #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
url.resolve does not resolve correct url in windows since it doesn't like backslashes.
|
The related code is in web-resource-inliner now. I don't think this issue exists there though since I run on windows and think there are some very similar test cases already. In any case, this PR could be closed here. |
|
This probably is not an issue anymore, at least this PR is invalid since the affected function does not exist anymore. I can't actually test this since we haven't used this for over a year or so, and the dependency were somewhere deep in the npm dependency chain. But I close this this PR purely because it is already invalid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url.resolve does not resolve correct url in windows since it doesn't
like backslashes.
If we inline following file:
getHrefContent returns undefined in Windows, although in Linux the css-file is read just fine. This does not effect other operating systems.