Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] comment and schema definition do not match #12895

Closed
2 tasks done
IslandRhythms opened this issue Jan 9, 2023 · 2 comments · Fixed by #13000
Closed
2 tasks done

[Doc] comment and schema definition do not match #12895

IslandRhythms opened this issue Jan 9, 2023 · 2 comments · Fixed by #13000
Assignees
@kailash360
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Milestone
6.9.1

Comments

@IslandRhythms
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

image
the comment calls it onModel but the schema definition and usage is docModel

@vkarpov15 could be a good first issue for the org person
@IslandRhythms IslandRhythms added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Jan 9, 2023
@kailash360
Copy link

Can I work on this?

@vkarpov15
Copy link
Collaborator

@kailash360 absolutely 👍

@vkarpov15 vkarpov15 added this to the 6.8.6 milestone Jan 22, 2023
vkarpov15 added a commit that referenced this issue Feb 4, 2023
@vkarpov15
docs(populate): fix out of date comment referencing onModel property
a2a57c8 
Fix #12895
@vkarpov15 vkarpov15 mentioned this issue Feb 4, 2023
Merged
vkarpov15 added a commit that referenced this issue Feb 4, 2023
@vkarpov15
Merge pull request #13000 from Automattic/vkarpov15/gh-12895
5099423 
docs(populate): fix out of date comment referencing `onModel` property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kailash360 kailash360

Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Milestone
6.9.1
Development

Successfully merging a pull request may close this issue.

docs(populate): fix out of date comment referencing onModel property Automattic/mongoose
3 participants
@vkarpov15 @IslandRhythms @kailash360